Skip to content

Commit 88d79e5

Browse files
committed
fix: additional fixes
1 parent c0612e7 commit 88d79e5

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

codecov/coverage/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def get_coverage_info(self, coverage_path: pathlib.Path) -> Coverage:
101101

102102
@abstractmethod
103103
def extract_info(self, data: dict) -> Coverage:
104-
raise NotImplementedError
104+
raise NotImplementedError # pragma: no cover
105105

106106
def get_diff_coverage_info( # pylint: disable=too-many-locals
107107
self,

codecov/template_files/pr.md.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{%- if not files %}
22

3-
_This PR does not seem to contain any modification to coverable code._
3+
_This PR does not include changes to coverable code or code with missing coverage._
44
{%- else -%}
55
<details><summary>Click to see coverage of changed files</summary>
66
<br>

tests/test_github.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,14 +361,19 @@ def test_post_comment_update(
361361
test_config,
362362
gh_client,
363363
):
364+
comment_with_no_marker = {
365+
'user': {'login': 'foo'},
366+
'body': 'Hey! Hi! How are you?',
367+
'id': 123,
368+
}
364369
comment = {
365370
'user': {'login': 'foo'},
366371
'body': 'Hey! Hi! How are you? marker',
367372
'id': 456,
368373
}
369374
session.register(
370375
'GET', f'/repos/{test_config.GITHUB_REPOSITORY}/issues/{test_config.GITHUB_PR_NUMBER}/comments'
371-
)(json=[comment])
376+
)(json=[comment_with_no_marker, comment])
372377
session.register(
373378
'PATCH',
374379
f'/repos/{test_config.GITHUB_REPOSITORY}/issues/comments/{comment["id"]}',

tests/test_template.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ def test_template_no_files(coverage_obj):
236236
marker='<!-- foo -->',
237237
subproject_id='foo',
238238
)
239-
assert '_This PR does not seem to contain any modification to coverable code.' in result
239+
assert '_This PR does not include changes to coverable code or code with missing coverage.' in result
240240
assert 'code.py' not in result
241241
assert 'other.py' not in result
242242

0 commit comments

Comments
 (0)