Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take full advantage of Probot #31

Closed
vicsufer opened this issue Oct 26, 2020 · 4 comments
Closed

Take full advantage of Probot #31

vicsufer opened this issue Oct 26, 2020 · 4 comments
Labels
discussion enhancement New feature or request wontfix This will not be worked on

Comments

@vicsufer
Copy link
Collaborator

vicsufer commented Oct 26, 2020

Idealista currently has a lot of repositories which is harder to maintain as new roles are being generated. We should consider using more features of probot to automate the maintenance of repos as much as possible.
I'm listting some ideas to discuss.

Release drafter

We can define a template for new releases which will be updated automatically with new merges to master until one maintainer publish it. Ant then the draft process start from the beginning.
Adventages:

  • Reduce effort in the release process.
  • We can place hints in the draft to review in new releases. Ex: In prom2teams, update setup.py for pypi release.

Remove merged branches

We should be doing this, but we are humans and make mistakes.
Advantages:

  • Avoid slip ups when merging branches.
  • Cleaner repository, only active branches in the remote repository.

WIP Merge protection

This would avoid merging wip pull requests by prefixing the pull request name with "WIP". This may be combined with not testing pull requests that are marked as WIP thus reducing load in travisci, because current configurations tests new commits in branches and PRs thus duplicating tests if PR is open.
Advantages:

  • Prevent merges of WIP PR by mistake of other contributor.
  • Reduce travis jobs (If an organization has only one concurrent job setup, duplication of testing process can block other repository builds)

Other

Other features to take into account: https://probot.github.io/apps/

@vicsufer vicsufer added enhancement New feature or request discussion labels Oct 26, 2020
@dortegau
Copy link
Member

I think it would be nice to do all of them.

We should investigate if it's possible to add these features to our existing repositories without being a pain in the neck.

@vicsufer
Copy link
Collaborator Author

vicsufer commented Oct 26, 2020

For starters @dortegau , we can try setting default reviewers at the organization level using github teams, Auto-assign probot app

For this we'll need to create the .github/auto_assign.yml which may be hard with all our repository (Maybe we can script this), but later on updating reviewers will be only a matter of adding and removing members of the team at the organization level.

@vicsufer
Copy link
Collaborator Author

It seems that Auto-assign app is not really supporting not working properly the integration with github teams.

Other option is use the CODEOWNERS file, however this will not allow merging with only just one approval unless we set a configuration on the team to enable autoassign which will route a PR review to only one member of the team. But this is not our use case where most part of the team review each PR.
image

@stale
Copy link

stale bot commented Jan 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 25, 2021
@stale stale bot closed this as completed Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants