Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove petsc_version_release testing option #29748

Open
GiudGiud opened this issue Jan 25, 2025 · 0 comments
Open

Remove petsc_version_release testing option #29748

GiudGiud opened this issue Jan 25, 2025 · 0 comments
Labels
C: TestHarness P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Jan 25, 2025

Bug Description

The petsc_version_release = true seems to have been used by MOOSE developers to tag tests that would be fixed in the next version release of PETSc. This skips the tests.
Unfortunately the follow up was not there and the tests were skipped forever.

It seems this was only done in the framework. Modules did not use this

This option should be removed, and it should be removed from these tests ASAP

Steps to Reproduce

See test suite and look at all these tests that never get run

tests/materials/material_dependency/tests:    petsc_version_release = true
tests/postprocessors/num_residual_eval/tests:    petsc_version_release = true
tests/multiapps/picard_failure/tests:    petsc_version_release = true
tests/multiapps/picard_failure/tests:    petsc_version_release = true
tests/multiapps/picard_failure/tests:    petsc_version_release = true
tests/multiapps/picard_catch_up/tests:      petsc_version_release = true
tests/preconditioners/pbp/tests:    petsc_version_release = true
tests/test_harness/extra_info:    petsc_version_release = true
tests/outputs/iterative/tests:    petsc_version_release = true

Impact

Skipped tests.
Potential regressions.
Not our process anymore.

[Optional] Diagnostics

No response

@GiudGiud GiudGiud added C: TestHarness P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations. labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: TestHarness P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Development

No branches or pull requests

1 participant