Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing error with sdef #607

Closed
MicahGale opened this issue Dec 5, 2024 · 1 comment
Closed

Parsing error with sdef #607

MicahGale opened this issue Dec 5, 2024 · 1 comment
Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". parsers are hard Examples of where MCNP syntax is complicated and should be simplified.

Comments

@MicahGale
Copy link
Collaborator

Describe the bug

This parsing error was reported

To Reproduce

problem = montepy.read_input("foo.imcnp")

Error Message (if any)

montepy.errors.ParsingError:     tests/models/success/HEU-MET-FAST-076_Case03.imcnp, line 140

       141| sdef cell=2 pos=0 0 -6.351 rad=d3 ext=d4 axs=0 0 1
    tests/models/success/HEU-MET-FAST-076_Case03.imcnp, line 141

    >  141| sdef cell=2 pos=0 0 -6.351 rad=d3 ext=d4 axs=0 0 1
          |      ^^^^ not expected here.
There was an error parsing "cell".
sly: Syntax error at line 1, token=TEXT

MCNP input file snippet

hi
C cells

c surfaces

sdef cell=2 pos=0 0 -6.351 rad=d3 ext=d4 axs=0 0 1

Version

  • Version 1.0.0alpha1dev306

Additional context

I need to double check that this is valid syntax. I thought we handled this already.

@MicahGale MicahGale added bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". parsers are hard Examples of where MCNP syntax is complicated and should be simplified. labels Dec 5, 2024
MicahGale added a commit that referenced this issue Jan 23, 2025
@MicahGale
Copy link
Collaborator Author

This is actually invalid syntax. Per section 5.8.1 the keyword is cel and not cell.

Therefore, this will not be adressed.

@MicahGale MicahGale closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". parsers are hard Examples of where MCNP syntax is complicated and should be simplified.
Projects
None yet
Development

No branches or pull requests

1 participant