Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEFECT] Changes to ARMA ROM in RAVEN has broken saved ROM pk files in tests #194

Closed
10 tasks done
j-bryan opened this issue Aug 3, 2022 · 2 comments · Fixed by #195
Closed
10 tasks done

[DEFECT] Changes to ARMA ROM in RAVEN has broken saved ROM pk files in tests #194

j-bryan opened this issue Aug 3, 2022 · 2 comments · Fixed by #195
Labels
defect Something isn't working priority-critical Task that is time sensitive and critical to project work

Comments

@j-bryan
Copy link
Collaborator

j-bryan commented Aug 3, 2022 •
edited by dgarrett622
Loading

Defect Description

Recent changes to the ARMA ROM in RAVEN have broken existing pickled ROMs like those used in the HERON integration tests. These ROMs need to be retrained with the latest version of RAVEN.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@j-bryan j-bryan added the defect Something isn't working label Aug 3, 2022
@j-bryan j-bryan mentioned this issue Aug 3, 2022
Merged
9 tasks
@dgarrett622 dgarrett622 linked a pull request Aug 3, 2022 that will close this issue
Updates pickled ARMA ROMs #195
Merged
9 tasks
@dgarrett622 dgarrett622 added the priority-critical Task that is time sensitive and critical to project work label Aug 3, 2022
@dgarrett622
Copy link
Collaborator

@PaulTalbot-INL is an email to users necessary for this?

@PaulTalbot-INL
Copy link
Collaborator

No email required for this. Might have been that an email should have gone out with the RAVEN merge, if anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect Something isn't working priority-critical Task that is time sensitive and critical to project work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates pickled ARMA ROMs j-bryan/HERON
3 participants
@PaulTalbot-INL @dgarrett622 @j-bryan