Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: improve wasm block sync efficiency #226

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

perf: improve wasm block sync efficiency #226

wants to merge 18 commits into from

Conversation

sherpalden
Copy link
Collaborator

@sherpalden sherpalden commented Jul 11, 2024 •
edited
Loading

  • Implemented batch query for block transactions.
  • Fetch only those transactions that are executed from the IBC handler contract.
  • Pushed IBCHeader to IBCHeaderCache for required block height only.
  • Removed block verification because the light client eventually verifies for any transaction. So, there's no need for additional verification in the relayer. After all, the relayer is trustless.

@sherpalden sherpalden self-assigned this Jul 11, 2024
@sherpalden sherpalden added wasm enhancement New feature or request labels Jul 11, 2024
@sherpalden sherpalden linked an issue Jul 11, 2024 that may be closed by this pull request
Optimize the efficiency of blocks and transactions fetching in wasm chains. #223
Open
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 283 lines in your changes missing coverage. Please review.

Project coverage is 11.02%. Comparing base (478dea5) to head (b370df3).
Report is 3 commits behind head on main.

Files Patch % Lines
relayer/chains/wasm/wasm_chain_processor.go 0.00% 179 Missing ⚠️
relayer/chains/wasm/query.go 0.00% 104 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   11.47%   11.02%   -0.46%     
==========================================
  Files          85       85              
  Lines       20409    20885     +476     
==========================================
- Hits         2342     2302      -40     
- Misses      17813    18339     +526     
+ Partials      254      244      -10
Files Coverage Δ
relayer/chains/wasm/provider.go 0.00% <ø> (-25.00%) ⬇️
relayer/chains/wasm/query.go 0.00% <0.00%> (ø)
relayer/chains/wasm/wasm_chain_processor.go 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcsainju bcsainju bcsainju left review comments

@debendraoli debendraoli Awaiting requested review from debendraoli

At least 1 approving review is required to merge this pull request.

Assignees

@sherpalden sherpalden

Labels
enhancement New feature or request wasm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize the efficiency of blocks and transactions fetching in wasm chains.
3 participants
@sherpalden @debendraoli @bcsainju