Skip to content

Commit bbb1156

Browse files
committed
Omit aria-valuenow for the indeterminate global progress bar.
Remove the unnecessary aria-valuetext attribute.
1 parent 6cd1ed0 commit bbb1156

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

index.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ <h1>jQuery File Upload Demo</h1>
9494
<!-- The global progress information -->
9595
<div class="span5 fileupload-progress fade">
9696
<!-- The global progress bar -->
97-
<div class="progress progress-success progress-striped active" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0" aria-valuetext="0%">
97+
<div class="progress progress-success progress-striped active" role="progressbar" aria-valuemin="0" aria-valuemax="100">
9898
<div class="bar" style="width:0%;"></div>
9999
</div>
100100
<!-- The extended global progress information -->
@@ -157,7 +157,7 @@ <h3 class="modal-title"></h3>
157157
<td class="error" colspan="2"><span class="label label-important">{%=locale.fileupload.error%}</span> {%=locale.fileupload.errors[file.error] || file.error%}</td>
158158
{% } else if (o.files.valid && !i) { %}
159159
<td>
160-
<div class="progress progress-success progress-striped active" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0" aria-valuetext="0%"><div class="bar" style="width:0%;"></div></div>
160+
<div class="progress progress-success progress-striped active" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0"><div class="bar" style="width:0%;"></div></div>
161161
</td>
162162
<td class="start">{% if (!o.options.autoUpload) { %}
163163
<button class="btn btn-primary">

js/jquery.fileupload-ui.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@
129129
!$.support.transition && 'progress-animated'
130130
)
131131
.attr('aria-valuenow', 100)
132-
.attr('aria-valuetext', '100%')
133132
.find('.bar').css(
134133
'width',
135134
'100%'
@@ -232,7 +231,6 @@
232231
var progress = parseInt(data.loaded / data.total * 100, 10);
233232
data.context.find('.progress')
234233
.attr('aria-valuenow', progress)
235-
.attr('aria-valuetext', progress + '%')
236234
.find('.bar').css(
237235
'width',
238236
progress + '%'
@@ -254,7 +252,6 @@
254252
globalProgressNode
255253
.find('.progress')
256254
.attr('aria-valuenow', progress)
257-
.attr('aria-valuetext', progress + '%')
258255
.find('.bar').css(
259256
'width',
260257
progress + '%'
@@ -274,7 +271,9 @@
274271
var that = $(this).data('fileupload');
275272
that._transition($(this).find('.fileupload-progress')).done(
276273
function () {
277-
$(this).find('.bar').css('width', '0%').parent().attr('aria-valuenow', '0').attr('aria-valuetext', '0%');
274+
$(this).find('.progress')
275+
.attr('aria-valuenow', '0')
276+
.find('.bar').css('width', '0%');
278277
$(this).find('.progress-extended').html('&nbsp;');
279278
that._trigger('stopped', e);
280279
}

test/index.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ <h2 id="qunit-userAgent"></h2>
5353
<!-- The global progress information -->
5454
<div class="span5 fileupload-progress fade">
5555
<!-- The global progress bar -->
56-
<div class="progress progress-success progress-striped active" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0" aria-valuetext="0%">
56+
<div class="progress progress-success progress-striped active" role="progressbar" aria-valuemin="0" aria-valuemax="100">
5757
<div class="bar" style="width:0%;"></div>
5858
</div>
5959
<!-- The extended global progress information -->
@@ -78,7 +78,7 @@ <h2 id="qunit-userAgent"></h2>
7878
<td class="error" colspan="2"><span class="label label-important">{%=locale.fileupload.error%}</span> {%=locale.fileupload.errors[file.error] || file.error%}</td>
7979
{% } else if (o.files.valid && !i) { %}
8080
<td>
81-
<div class="progress progress-success progress-striped active" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0" aria-valuetext="0%"><div class="bar" style="width:0%;"></div></div>
81+
<div class="progress progress-success progress-striped active" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="0"><div class="bar" style="width:0%;"></div></div>
8282
</td>
8383
<td class="start">{% if (!o.options.autoUpload) { %}
8484
<button class="btn btn-primary">

0 commit comments

Comments
 (0)