Remove server button not working (X connects to server instead of removing)

[skillman623]

On the server list, the remove server button no longer functions.
I remember it functioning at one point.
Currently it connects to the server instead of removing it from the list.

OS Windows 10 home.
Graphics Nvidia.

[iceiix]

Confirmed, clicking "X" in the server list connects to the server on my system as well. "E" interestingly works as expected (edit). The buttons are highlighted correctly on mouseover, so this probably isn't a symptom of the mouse tracking issues (#334). Will have to regress to see when this broke.

Testing older commits, reproduces on:
4e9cda2
287fb3f

delete_entry in src/screen/server_list.rs:

stevenarella/src/screen/server_list.rs

Lines 197 to 210 in 4e9cda2

	// Delete entry button
	let delete_entry = ui::ButtonBuilder::new()
	.position(0.0, 0.0)
	.size(25.0, 25.0)
	.alignment(ui::VAttach::Bottom, ui::HAttach::Right)
	.attach(&mut *back.borrow_mut());
	{
	let mut btn = delete_entry.borrow_mut();
	let txt = ui::TextBuilder::new()
	.text("X")
	.alignment(ui::VAttach::Middle, ui::HAttach::Center)
	.attach(&mut *btn);
	btn.add_text(txt);
	}

no btn.add_click_func, how did this work? Appears the click event is going through to the parent item (// Make whole entry interactable, ... .replace_screen(Box::new(super::connecting::Connecting::new(&address)));).

Workaround: manually edit servers.json to remove the server entry

[iceiix]

Thinkofname/steven#49