Skip to content
This repository has been archived by the owner on Apr 3, 2019. It is now read-only.

Only re-require Composer packages if they aren't already installed #89

Open
rjkip opened this issue Feb 17, 2017 · 2 comments
Open

Only re-require Composer packages if they aren't already installed #89

rjkip opened this issue Feb 17, 2017 · 2 comments
Labels
Milestone

Comments

@rjkip
Copy link
Contributor

rjkip commented Feb 17, 2017

After having run QA Tools once, subsequent runs will cause composer require calls for all package dependencies. This can cause the versions of tools to be upgraded. In my opinion, this is not expected behaviour and upgrading packages is a manual task.

@rjkip rjkip added the bug label Feb 17, 2017
@rjkip rjkip added this to the 3.1.0 milestone Feb 17, 2017
@rjkip
Copy link
Contributor Author

rjkip commented Feb 17, 2017

@DRvanR wrote:

Agreed, possible solutions:

  • parse a dry-run output (not really in favor)
  • A "composersystemthingymabob" tracks the currently required packages based on given answers to previous configs (could be in the TodoList or something like that when registering new ComposerDevDepTask) and allows to only install new packages (As they can be identified from not being a previously given answer) - optionally offering to upgrade packages using require.

@rjkip
Copy link
Contributor Author

rjkip commented Feb 17, 2017

Another possible solution: change the Composer require API to only require new or changed packages/versions. This way repeated requires of phpunit/phpunit:^5 only result in one actual require request to Composer, until, for instance, the version constraint is changed to phpunit/phpunit:^6. Should be pretty easy.

rjkip pushed a commit that referenced this issue Feb 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant