Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results vary with tolerance #23

Open
bramvdh91 opened this issue Oct 3, 2018 · 3 comments
Open

Results vary with tolerance #23

bramvdh91 opened this issue Oct 3, 2018 · 3 comments
Labels
destest Issues related to WP3 destest

Comments

@bramvdh91
Copy link

As @FelixBue's results show, the network simulation results (mostly annual energy, to a lesser degree also heat losses) vary quite alarmingly with the tolerance setting for the solver. I have tested the same for the outlet temperatures in the example IBPSA.Fluid.FixedResistances.Examples.PlugFlowPipe and this also shows differences, as seen below.
startrise
steady

This also shows the error is not proportional to the tolerance. I still need to check if the deviations are of the same order as those shown in the DESTEST network.

@bramvdh91 bramvdh91 added the destest Issues related to WP3 destest label Oct 3, 2018
@Mathadon
Copy link
Member

Mathadon commented Oct 3, 2018

Possibly these results are caused by not having a lot of states in the model, due to which the integrator can easily satisfy its tolerance criterion even when taking too large steps. This is easy to check by using Euler integration with a fixed small time step. If this produces the expected results, then I would look towards the integrator. What integrator are you currently using?

@bramvdh91
Copy link
Author

Using Dassl for now. Indeed, with Euler the results are the same irrespective of tolerance. Will check if Euler can handle the DESTEST network as well ;)

@Mathadon
Copy link
Member

Mathadon commented Oct 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
destest Issues related to WP3 destest
Projects
None yet
Development

No branches or pull requests

2 participants