Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected occupancy profile #727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

icupeiro
Copy link
Contributor

This tackles #726

@dhblum dhblum self-requested a review January 19, 2025 14:06
@dhblum
Copy link
Collaborator

dhblum commented Jan 19, 2025

Thanks @icupeiro for reporting and the PR. Will review this week when I get a chance.

@icupeiro
Copy link
Contributor Author

More info about this:

This is the plot of the lower setpoint (blue) + occupancy (red), which is completely misaligned

image

Corrected profile is shown here

image

@dhblum
Copy link
Collaborator

dhblum commented Jan 20, 2025

Thanks @icupeiro this is helpful.

Copy link
Collaborator

@dhblum dhblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@icupeiro I double checked this. It seems alignment between the occupancy count and zone temperature set point is ok within the FMU simulation. And, your correction to Resources/occupancy.csv indeed seems to fix the alignment with what's simulated in the FMU from a time perspective. However, through further checking, I discovered that it seems:

  1. The Resources/occupancy.csv does not match the decrease of occupancy number in the summer, as seen in the FMU simulation.
  2. The Resources/internalGains.csv does not match the internal gain convective and radiant heat flows for each zone as the FMU simulates (what I believe are variables mod.occupancy.heatPortCon[1].Q_flow and mod.occupancy.heatPortRad[1].Q_flow in the wrapped.fmu, plotted below)

See plot below (Note that I only plotted one FMU simulation zone since they are both the same in the simulation. I suppose I could have done that for the Resources variables too, but plotted both zones to double check). Can you please confirm if there were updates to the model's occupancy simulation and internal gains that may not have been reflected in the csv's in the Resources directory? Would you be able to further correct Resources/occupancy.csv and Resources/internalGains.csv as appropriate?

Figure_1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants