Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported changes from Buildings for CDL.Logica.TrueFalseHold #1967

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented Feb 10, 2025

This closes #1966

@mwetter mwetter requested a review from FWuellhorst February 12, 2025 23:38
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but I am wondering if a documentation warning or similar should be raised if users use cvode with dymola < 2025x or other tools. Or is this irrelevant as the bug error is not present in cvode in OM or FMU-export?

@mwetter
Copy link
Contributor Author

mwetter commented Feb 14, 2025

This issue only happens if the block is used in certain models, and with Dymola 2024x and the CVode solver, so a blank warning is in my opinion difficult.

@mwetter mwetter merged commit 0d48fc8 into master Feb 14, 2025
3 checks passed
@mwetter mwetter deleted the issue1966_TrueFalseHold branch February 14, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate changes to TrueFalseHold
2 participants