Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unprotect dh in IBPSA.Airflow.Multizone.BaseClasses.DoorDiscretized #1935

Open
kldjonge opened this issue Oct 4, 2024 · 0 comments · May be fixed by #1936
Open

Unprotect dh in IBPSA.Airflow.Multizone.BaseClasses.DoorDiscretized #1935

kldjonge opened this issue Oct 4, 2024 · 0 comments · May be fixed by #1936

Comments

@kldjonge
Copy link
Contributor

kldjonge commented Oct 4, 2024

For non-vertical discretised large openings, the baseclass IBPSA.Airflow.Multizone.BaseClasses.DoorDiscretized can not be used because it requires overriding the protected parameter dh which is not good Modelica. However, with a small change the baseclass can be used for a broader purpose which matches the needs in IDEAS.

It can be solved by the prefix of dh, hAg and hBg as input in stead of parameter
@kldjonge kldjonge linked a pull request Oct 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue1935_unprotect dh and change prefixes to input ibpsa/modelica-ibpsa
1 participant
@kldjonge