Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add MixingVolumes #9

Open
Mathadon opened this issue Dec 10, 2019 · 3 comments · May be fixed by #10
Open

add MixingVolumes #9

Mathadon opened this issue Dec 10, 2019 · 3 comments · May be fixed by #10
Assignees
@Mathadon

Comments

@Mathadon
Copy link
Member

This issue is to add the MixingVolume model to the library.
@Mathadon Mathadon self-assigned this Dec 10, 2019
@Mathadon
Copy link
Member Author

Looking into this. The merge script has a bug when adding new files since the git-diff does not recognize the not-yet-copied file.

Mathadon added a commit that referenced this issue Jan 13, 2020
@Mathadon
added MixingVolume and dependencies to merge script for #9
427edeb
@Mathadon Mathadon linked a pull request Jan 13, 2020 that will close this issue
Open
@dhblum
Copy link
Collaborator

dhblum commented Jan 13, 2020

Is the bug addressed currently in #10? Or you are still looking into it?

@Mathadon
Copy link
Member Author

The bug has been fixed and pushed to https://github.com/Mathadon/BuildingsPy/tree/issue278_mergeMpc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mathadon Mathadon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue9 mixing volume ibpsa/modelica-ibpsa-mpc
2 participants
@Mathadon @dhblum