Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement EnvironmentMetrics #3045

Open
gtmills opened this issue Apr 7, 2021 · 10 comments
Open

Implement EnvironmentMetrics #3045

gtmills opened this issue Apr 7, 2021 · 10 comments
Assignees
Labels
Migrate-No Do not migrate to Jira prio_high_1 ReadyForDev Stories ready for development work
Milestone

Comments

@gtmills
Copy link

gtmills commented Apr 7, 2021

https://redfish.dmtf.org/schemas/v1/EnvironmentMetrics.v1_0_0.json

Need EnvironmentMetrics for PowerConsumedWatts
https://github.com/search?q=org%3Aopenbmc+PowerConsumedWatts&type=code

PowerConsumedWatts is called PowerWatts in EnvironmentMetrics

For now just put EnvironmentMetrics out on Chassis and implement PowerWatts

@rfrandse rfrandse added this to the A.1.212 milestone Apr 7, 2021
@gtmills gtmills added ReadyForDev Stories ready for development work prio_high_1 labels May 7, 2021
@zhanghaodi
Copy link

@gtmills There are some questions about the data that needs to be implemented.

1.For the "TemperatureCelsius";
See the description in the introduction, this is the reading value of the sensor temperature,
and the data comes from CPU1Temp,
My question is as follows:
1>If there are two or more CPUs, how to choose?
Should all the CPU data be listed, or just take the first one;
or take the average of all the data (this method is very undesirable but it is also possible )
2>On our machine, the PSU is not named CPU1Temp, but cpu0,
and there is no reading value in the data under cpu0.
How to solve this? Is it necessary to add a CPU1Temp related sensor first,
Could you provide relevant help?
3>And its type is null,
This is a little unclear.

2.For the "PowerWatts";
similar to the question above,it is the total power,
in our machine,there is no /redfish/v1/Chassis/1U/Sensors/TotalPower,
how can this be achieved,please give some help.

@mzipse mzipse modified the milestones: A.1.212, A.1.213.9 May 11, 2021
@zhanghaodi
Copy link

@gtmills
Copy link
Author

gtmills commented May 13, 2021

Sorry for not responding sooner, at this time we just need PowerWatts in EnvironmentMetrics.
That is what we are trying to replace.
I am fine if we also want to add Fan speeds but let's make sure we concentrate on PowerWatts which is the replacement for PowerConsumedWatts

@zhanghaodi
Copy link

@gtmills Okay, for PowerWatts in EnvironmentMetrics.
The data comes from /redfish/v1/Chassis/chassisId/Sensors/TotalPower;
For the sensor called TotalPower, it does not exist on our machine;
this should be about reading the power of the entire chassis; how to get this data.
Does the sensor module need to add a sensor named TotalPower first?

@gtmills
Copy link
Author

gtmills commented May 14, 2021

The data comes from /redfish/v1/Chassis/chassisId/Sensors/TotalPower;

Yes, https://github.com/openbmc/bmcweb/blob/9a128eb3fc3008f802974360e98de6495ed1a66b/redfish-core/lib/sensors.hpp#L1007
https://github.com/search?q=org%3Aopenbmc+total_power&type=code

It only exists on ours when the system is booted.

Does the sensor module need to add a sensor named TotalPower first?

Anyway you can a sensor like this to your machine?

@zhanghaodi
Copy link

Thank you, I am trying to make a similar sensor exist in our machine.

@gtmills
Copy link
Author

gtmills commented Oct 6, 2021

@zhanghaodi Can we pull this one and #2793 in downstream?

@lxwinspur
Copy link

@zhanghaodi Can we pull this one and #2793 in downstream?

ibm-openbmc/bmcweb#135

@mzipse
Copy link
Contributor

mzipse commented Jun 1, 2022

refresh again

@mzipse mzipse added the Migrate-No Do not migrate to Jira label Oct 26, 2022
@gtmills
Copy link
Author

gtmills commented Dec 12, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Migrate-No Do not migrate to Jira prio_high_1 ReadyForDev Stories ready for development work
Projects
None yet
Development

No branches or pull requests

5 participants