Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLDM: (MEX LED) Process the Host PDRs for the state sensors & effecters with state set ID IdentifyState #2821

Open
tomjoseph83 opened this issue Dec 17, 2020 · 3 comments
Assignees
Labels
Migrate-No Do not migrate to Jira prio_high_2 ReadyForDev Stories ready for development work
Milestone

Comments

@tomjoseph83
Copy link

If there are state sensors with state set ID IdentifyState.

1.Lookup the FRU object associated with the sensor
2.Create the LED D-Bus object /xyz/openbmc_project/led/groups/ object
3.PLDM daemon implements the xyz.openbmc_project.Association.Definitions to create association between FRU and LED D-Bus objects
4.Initialize the Identify D-Bus property by issuing GetSensorReading
5.Add this sensor to the PlatformEventMessage map to update D-bus property value when the PHYP detects a change

If there is a state effecter with the identify state to the corresponding FRU bind the SetProperty of the LED to a StateSetEffecter on the corresponding effecter.

@tomjoseph83 tomjoseph83 added prio_high_2 ReadyForDev Stories ready for development work labels Dec 17, 2020
@rfrandse rfrandse added this to the A.1.211 milestone Dec 17, 2020
@rfrandse rfrandse modified the milestones: A.1.211, A.1.212.3 Apr 8, 2021
@nmuruli nmuruli changed the title PLDM: Process the Host PDRs for the state sensors & effecters with state set ID IdentifyState PLDM: (MEX LED) Process the Host PDRs for the state sensors & effecters with state set ID IdentifyState Apr 30, 2021
@nmuruli nmuruli modified the milestones: A.1.212.3, A.1.213.8 Apr 30, 2021
@lxwinspur
Copy link

@tomjoseph83 @sampmisr

Could you kindly explain this issue?
I have a couple of questions:

  1. PLDM daemon needs to create /xyz/openbmc_project/led/groups/<name>? If so, What is the difference between this and the phosphor-led-manager service ?
  2. If there is a state effecter with the identify state to the corresponding FRU bind the SetProperty of the LED to a StateSetEffecter on the corresponding effecter.

sorry, I do not understand?

Thanks a lot

@lxwinspur lxwinspur self-assigned this Jun 16, 2021
@manojkiraneda
Copy link

manojkiraneda commented Sep 22, 2021

@tomjoseph83 @sampmisr

Could you kindly explain this issue?
I have a couple of questions:

1. PLDM daemon needs to create ` /xyz/openbmc_project/led/groups/<name>`? If so, What is the difference between this and the `phosphor-led-manager` service ?

Any dbus object can be hosted by any services, its not always the case that led objects should be created by led-manager. In this case the led- objects are created by pldm, based on whether the set set ID identify state is implemented on those state sensors.

2. > If there is a state effecter with the identify state to the corresponding FRU bind the SetProperty of the LED to a StateSetEffecter on the corresponding effecter.

sorry, I do not understand?

once , pldm hosts the led group object, we will have to implement the set and get operations of the Asserted Property.

xyz.openbmc_project.Led.Group       interface -         -            -
.Asserted                           property  b         false        emits-change writable

When some one sets the Asserted dbus property, I think we need to map the effecter that implements the identity led state set ,& call SetEffecterStates command with the right effecter, so that the LED on the MEX will be on.

@mzipse mzipse added the Migrate-No Do not migrate to Jira label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Migrate-No Do not migrate to Jira prio_high_2 ReadyForDev Stories ready for development work
Projects
None yet
Development

No branches or pull requests

6 participants