Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a simplified option for to_graph #10054

Open
1 task done
djouallah opened this issue Sep 7, 2024 · 8 comments
Open
1 task done

feat: add a simplified option for to_graph #10054

djouallah opened this issue Sep 7, 2024 · 8 comments
Labels
feature Features or general enhancements

Comments

@djouallah
Copy link

Is your feature request related to a problem?

to_graph is really good but can be very hard to read for a complex transformation

What is the motivation behind your request?

I am just looking for a simple diagram that show relationship between tables and not show the details at the column level

Describe the solution you'd like

something less verbose for a lack of better word compared to the detailed output,

What version of ibis are you running?

9.3

What backend(s) are you using, if any?

duckdb, mssql and spark

Code of Conduct

  • I agree to follow this project's Code of Conduct
@djouallah djouallah added the feature Features or general enhancements label Sep 7, 2024
@cpcloud
Copy link
Member

cpcloud commented Sep 9, 2024

Thanks for the issue!

Can you show an example of what you're trying to get rid of or simplify?

@cpcloud
Copy link
Member

cpcloud commented Sep 9, 2024

@turntable-justin @deepyaman Mentioned you had built something like this already.

@deepyaman
Copy link
Contributor

@turntable-justin @deepyaman Mentioned you had built something like this already.

@turntable-justin Actually, as I'm rereading this issue, I think I partially misunderstood the issue. 😅 That said, I don't 100% remember the level of detail on what you'd shown me on a text-based IR representation—if it was simpler, or if it was the full graph represented in text.

@djouallah
Copy link
Author

basically something like this, I want to see only the relationship at the table level not the column level
image

@turntable-justin
Copy link

turntable-justin commented Sep 9, 2024 via email

@deepyaman
Copy link
Contributor

Yeah ours is a representation of an IR that doesn't require graphviz and can just print in the terminal. Something like the below... [image: Screenshot 2024-09-09 at 5.06.00 PM.png]

On Mon, Sep 9, 2024 at 5:00 PM Mimoune @.> wrote: basically something like this, I want to see only the relationship at the table level not the column level image.png (view on web) https://github.com/user-attachments/assets/ec00e292-b139-4bec-ad17-f55ffc0681e2 — Reply to this email directly, view it on GitHub <#10054 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5HSLR3F2YNA6SUYBDUZ5F3ZVYK6RAVCNFSM6AAAAABN2BYDN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZZGIZDQOJZGI . You are receiving this because you were mentioned.Message ID: @.>

@turntable-justin Don't think the image came through via email reply.

@turntable-justin
Copy link

Like below. Sorry about that!

Screenshot 2024-09-09 at 5 55 11 PM

@deepyaman
Copy link
Contributor

basically something like this, I want to see only the relationship at the table level not the column level image

I wonder how valuable this would be for most users? I'd expect, in most cases, you join a handful of tables together at most (there are some exceptions that come to mind, like when you join all of the input feature tables to create a master table for machine learning). If you're doing any sort of complicated logic, it's probably a good idea to represent these as inputs to a function, and then there are various tools (e.g. ML pipeline frameworks) that provide visualizations of these workflows. Not sure if Ibis needs to operate at this level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements
Projects
Status: backlog
Development

No branches or pull requests

4 participants