Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing commits around 16:40 UTC causes tests to fail. #133

Open
binh-dam-ibigroup opened this issue Jan 25, 2021 · 0 comments
Open

Pushing commits around 16:40 UTC causes tests to fail. #133

binh-dam-ibigroup opened this issue Jan 25, 2021 · 0 comments

Comments

@binh-dam-ibigroup
Copy link
Collaborator

Observed behavior

Pushing commits any day around 16:40 UTC (11:40 am EST, 8:40 am PST) causes CI tests to fail.

This is related to a trip start time used in the monitored trip tests. A commit around the trip start time (e.g. from 1 hour before start to the end time of the trip) results in an extra mock OTP request being performed by the trip monitor to obtain real-time trip status for an upcoming/active trip, causing a mismatch between the expected and actual number of mock OTP requests.

Expected behavior

The tests should not fail.

Steps to reproduce the problem

Push a commit before the stated time.

Any special notes on configuration used

NA

Version of otp-middleware and/or OpenTripPlanner if applicable (exact commit hash or branch name)

Latest dev.

@binh-dam-ibigroup binh-dam-ibigroup changed the title Pushing commits before 16:40 UTC causes tests to fail. Pushing commits around 16:40 UTC causes tests to fail. Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant