From 0b2568c7781919f8d6a7d2a82757edc83f0706a6 Mon Sep 17 00:00:00 2001 From: MateuszKolankowski Date: Fri, 7 Mar 2025 15:30:09 +0100 Subject: [PATCH 1/2] Added rector rule to replace method FieldNameResolver::getFieldNames to FieldNameResolver::getFieldTypes --- src/contracts/Sets/ibexa-50.php | 11 +++++++ ...ver-getfieldnames_to_getfieldtypes.php.inc | 31 +++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 tests/lib/Sets/Ibexa50/Fixture/change_property_to_method_fieldnameresolver-getfieldnames_to_getfieldtypes.php.inc diff --git a/src/contracts/Sets/ibexa-50.php b/src/contracts/Sets/ibexa-50.php index 563b912..037b9a6 100644 --- a/src/contracts/Sets/ibexa-50.php +++ b/src/contracts/Sets/ibexa-50.php @@ -228,4 +228,15 @@ 'isContainer' => 'isContainer', ], ]); + + $rectorConfig->ruleWithConfiguration( + RenameMethodRector::class, + [ + new MethodCallRename( + 'Ibexa\Core\Search\Common\FieldNameResolver', + 'getFieldNames', + 'getFieldTypes' + ), + ] + ); }; diff --git a/tests/lib/Sets/Ibexa50/Fixture/change_property_to_method_fieldnameresolver-getfieldnames_to_getfieldtypes.php.inc b/tests/lib/Sets/Ibexa50/Fixture/change_property_to_method_fieldnameresolver-getfieldnames_to_getfieldtypes.php.inc new file mode 100644 index 0000000..2f79759 --- /dev/null +++ b/tests/lib/Sets/Ibexa50/Fixture/change_property_to_method_fieldnameresolver-getfieldnames_to_getfieldtypes.php.inc @@ -0,0 +1,31 @@ +getFieldNames()]; + } +} + +?> +----- +getFieldTypes()]; + } +} + +?> From d277a9d16c8ddfb70b33c3c99bae75e1aada3384 Mon Sep 17 00:00:00 2001 From: MateuszKolankowski Date: Fri, 7 Mar 2025 15:49:08 +0100 Subject: [PATCH 2/2] Added rector rule to replace method FieldNameResolver::getFieldNames to FieldNameResolver::getFieldTypes --- src/lib/Rule/ReplaceInterfaceRector.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/Rule/ReplaceInterfaceRector.php b/src/lib/Rule/ReplaceInterfaceRector.php index 41e1481..b9218d5 100644 --- a/src/lib/Rule/ReplaceInterfaceRector.php +++ b/src/lib/Rule/ReplaceInterfaceRector.php @@ -55,7 +55,7 @@ public function getNodeTypes(): array /** * @param \PhpParser\Node\Stmt\Class_ $node */ - public function refactor(Node $node): ?Node + public function refactor(Node $node): Node { foreach ($node->implements as $key => $implement) { if ($this->isName($implement, $this->interfaceToBeReplaced)) {