Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert foo.com #8

Open
lsmith77 opened this issue Nov 28, 2013 · 4 comments
Open

convert foo.com #8

lsmith77 opened this issue Nov 28, 2013 · 4 comments

Comments

@lsmith77
Copy link
Contributor

imho it would make sense to also convert test.com type strings

1) Liip\UrlAutoConverterBundle\Tests\Extension\UrlAutoConverterTwigExtensionTest::testAutoConvertUrls with data set #1 ('Lorem ipsum dolor sit amet, <a href="http://test.com">test.com</a> consectetuer adipiscing', 'Lorem ipsum dolor sit amet, test.com consectetuer adipiscing')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, <a href="http://test.com">test.com</a> consectetuer adipiscing'
+'Lorem ipsum dolor sit amet, test.com consectetuer adipiscing'
1) Liip\UrlAutoConverterBundle\Tests\Extension\UrlAutoConverterTwigExtensionTest::testAutoConvertUrls with data set #3 ('Lorem ipsum dolor sit amet, lala <a href="http://subtest.test.com">subtest.test.com</a> aksjdhasd.', 'Lorem ipsum dolor sit amet, lala subtest.test.com aksjdhasd.')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, lala <a href="http://subtest.test.com">subtest.test.com</a> aksjdhasd.'
+'Lorem ipsum dolor sit amet, lala subtest.test.com aksjdhasd.'
@prionkor
Copy link

+1 on this. If not default we could turn this feature on with some flags.

@dbu
Copy link

dbu commented May 6, 2014

ping

@iamcal
Copy link
Owner

iamcal commented May 7, 2014

feel free to send a pull request

doing this gets complicated - what TLDs do you support? do some TLDs requires paths? (else the perl script foo.pl is suddenly a URL)

@cweiske
Copy link

cweiske commented Jan 11, 2021

That list is called the "public suffix list" and can be found at https://publicsuffix.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants