Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load-from-path with strings causes errors if used without parens #19

Open
iainctduncan opened this issue Oct 12, 2021 · 8 comments
Open

Comments

@iainctduncan
Copy link
Owner

using load-from-path is working fine on windows when in parens, but trying to use it with a quoted filename without parens is doing all kinds of weird crap. A better solution would be to implement read as I have done in s4m so one can do

|read file-no-quotes.scm|

@iainctduncan
Copy link
Owner Author

hmm, seems like the reader was just borked. but still, the read command would be better

@iainctduncan iainctduncan changed the title need the "read" function from s4m, load-from-path has windows issues port the "read" message handler from s4m Oct 12, 2021
@Lucarda
Copy link
Contributor

Lucarda commented Oct 12, 2021

using load-from-path is working fine on windows when in parens, but trying to use it with a quoted filename without parens is doing all kinds of weird crap

This is also happening on Linux.

@iainctduncan
Copy link
Owner Author

good to know, I'll make it a priority. I've had this happen on s4m too, where it's possible to bork the reader by not having input close properly, but have not been able to consistently replicate the bug.

@iainctduncan
Copy link
Owner Author

It would be good to know if it only happens to you from the no-parens version.

@Lucarda
Copy link
Contributor

Lucarda commented Oct 12, 2021

Yep, that's correct.
Only happening to "no-parens version" both on Linux and Windows (both tested only on 64bit arch).

@Lucarda
Copy link
Contributor

Lucarda commented Oct 12, 2021

Something that can help for later debugging:

Only on Linux:

  • open [pd loading-files] sub-patch

  • click [load-from-path "help-1.scm"(

    • error
  • click [(load-from-path "help-2.scm")(

    • works
  • go back and click [load-from-path "help-1.scm"(

    • now it works.

On Windows it does not behave the same. It always gives errors when clicking [load-from-path "help-1.scm"(

@iainctduncan
Copy link
Owner Author

going to rename this ticket as I would still like to figure out what is going wrong, but have now added a read function, so using load-from-path in patchers is no longer necessary. If anyone gets these errors using the read message, please let me know, but as it doesn't use strings, I can't make the errors so far.

@iainctduncan iainctduncan changed the title port the "read" message handler from s4m load-from-path with strings causes errors if used without parens Oct 15, 2021
@iainctduncan
Copy link
Owner Author

there is now a read message that seems to work reliably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants