Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling disconnected graphs #12

Closed
ugurdogrusoz opened this issue Dec 2, 2020 · 3 comments
Closed

Handling disconnected graphs #12

ugurdogrusoz opened this issue Dec 2, 2020 · 3 comments
Assignees
@ugurdogrusoz
Labels
enhancement Enhancement to existing feature

Comments

@ugurdogrusoz
Copy link
Contributor

When a graph is disconnected and packing of components is enabled and a cluster spans multiple components, we should merge the multiple components spanning the same cluster and process accordingly. In other words, the fact that two nodes are in the same cluster should force the components that these nodes are in to be combined.
@ugurdogrusoz ugurdogrusoz added the enhancement Enhancement to existing feature label Dec 2, 2020
canbax added a commit that referenced this issue Dec 2, 2020
@canbax
#12 bug fix, run build:min for minified build
be5ccb8
@canbax canbax removed their assignment Dec 2, 2020
@ugurdogrusoz ugurdogrusoz self-assigned this Dec 7, 2020
@ugurdogrusoz
Copy link
Contributor Author

This does not work. Load sample and group highlighted nodes together showing groups as circles and you get:
visuall (2)

@ugurdogrusoz ugurdogrusoz assigned canbax and unassigned ugurdogrusoz Dec 7, 2020
canbax added a commit to ugurdogrusoz/visuall that referenced this issue Dec 7, 2020
@canbax
iVis-at-Bilkent/cytoscape.js-cise#12 fix to use the latest commit
43a73e6
canbax added a commit to ugurdogrusoz/visuall that referenced this issue Dec 7, 2020
@canbax
iVis-at-Bilkent/cytoscape.js-cise#12 delete node_modules and lock fil…
480f221 
…e then run `npm i`
@canbax canbax removed their assignment Dec 7, 2020
@ugurdogrusoz ugurdogrusoz self-assigned this Dec 7, 2020
@ugurdogrusoz
Copy link
Contributor Author

After having struggled selecting the two nodes, I finally produced this problem:
ezgif com-gif-maker (2)

@ugurdogrusoz ugurdogrusoz assigned canbax and unassigned ugurdogrusoz Dec 7, 2020
@canbax
Copy link
Member

canbax commented Dec 8, 2020

below gif is how I reproduce this bug. Also, I noticed sometimes Shift + Drag zooms in but I don't know how it happens. This should be related to the view-utilities extension because Visuall uses it for marquee zooming. (Visuall only changes the cursor on ctrl+shift pressed together)

RMWVpwLqna

canbax added a commit that referenced this issue Dec 8, 2020
@canbax
#12 disjoint set implementation aded
9b4a7a9
@canbax canbax removed their assignment Dec 8, 2020
@ugurdogrusoz ugurdogrusoz self-assigned this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ugurdogrusoz ugurdogrusoz

Labels
enhancement Enhancement to existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ugurdogrusoz @canbax