-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDZero OSD @1080 -left side of stat labels and right side of some stat values missing #10537
Comments
To me it looks like the stats screen is being clipped to 4:3. There is also text missing from the right side of the stats. The system messages is drawn by something completely different to the stats screen. I don't get why this clipping is occurring when the system messages are moved. But maybe having it left switches to 16:9, but centred it drops to 4:3? I'll see what I can check out in HITL and with Walksnail. |
This issue has been resolved in PR #10540 |
The low res OSD was added to improve OSD refresh rate, especially for AHI. This is a bandwidth limitation and I believe affects all HDZero devices. I expect there will be a number of upset people if the option is removed. People that use AHI get really annoyed when the refresh rate is low. I think @geoffsim is the expert on this code and should be consulted before making changes. In about a week I will have some time to test the reported behavior. @pitts-mo it would be helpful to know if you are using goggles or VRX. |
I use artificial horizon with HDZero Goggles.
If a similar feature needs to be re-added I think we will need to set it static or at least enhance the logic as to prevent it from erroneously clipping the sides of the OSD. |
@pitts-mo you need to check what the VTX code is doing. My recollection is that the performance improvement was from the reduced bandwidth between VTX and VRX |
Seems like a comparison of update rate between an OSD profile with only artificial horizon centered and another OSD profile with only artificial horizon left might be helpful. (I might be able to look into this on Sunday) I see @mmosca's comment on PR #10540 , INAV does not yet support getting display size from VTX and his suggestion of an SD mode makes a lot of sense if this is still needed. |
Tested inav 8.0.0-rc3 with my normal OSD profile, OSD profile w/AHI only, and OSD profile w/AHI & pilot name upper left. I am unable to perceive any AHI performance difference between these three profiles. In fast movement the outer dots of the AHI were so fast they were almost impossible to see. I am using HDZero Goggle and Race v3 VTX running recent builds from master. If someone reports they are still affected by the old slow OSD problem we can navigate toward a more appropriate implementation or solution.
|
Did you test in 1080p 30 only, or also 720p 60?
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: pitts-mo ***@***.***>
Sent: Thursday, December 19, 2024 4:22:57 PM
To: iNavFlight/inav ***@***.***>
Cc: aviphysics ***@***.***>; Comment ***@***.***>
Subject: Re: [iNavFlight/inav] HDZero OSD @1080 -left side of stat labels and right side of some stat values missing (Issue #10537)
Tested inav 8.0.0-rc3 with my normal OSD profile, OSD profile w/AHI only, and OSD profile w/AHI & pilot name upper left. I am unable to perceive any AHI performance difference between these three profiles. In fast movement the outer dots of the AHI were so fast they were almost impossible to see.
I am using HDZero Goggle and Race v3 VTX running recent builds from master.
If someone reports they are still affected by the old slow OSD problem we can navigate toward a more appropriate implementation or solution.
—
Reply to this email directly, view it on GitHub<#10537 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGOG4C4N3R3U4HBGAAVGOL2GNPODAVCNFSM6AAAAABTU2F3JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJWGAYDMOBWHA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
I had performed the actual comparison at 1080p but I did also verify the AHI updated extremely fast in 720p mode as well. The #8006 issue suggests to me that HDZeros OSD update rate at the time was horrible regardless of FC firmware. The timing of code changes makes me suspect HDZero users running pre v1.0.0 firmware would experience the old lag issue. @aviphysics If your concern persists please provide the test conditions where you find the slow OSD rate still exists. |
Current Behavior
On HDZero OSD @1080 the left side of OSD stat labels and right side of some stat values are missing when the current OSD profile contains only the system messages element centered on screen. I suspect this issue will occur when there are not any OSD elements far enough to the left or right side within the current OSD profile.
Steps to Reproduce
-HDZero OSD @1080
-only the system messages element centered in screen (no other elements)
-arm
-disarm
Expected behavior
The expected behavior is to see the entire OSD stats panel when OSD is enabled regardless of OSD element placements within the current OSD profile.
Temporary Workaround:
The system messages element dragged to the left edge of the OSD profile.
Suggested solution(s)
?
The text was updated successfully, but these errors were encountered: