Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox keyboard navigation does not follow currently selected item. #61

Open
CasperH2O opened this issue May 24, 2024 · 9 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@CasperH2O
Copy link

Describe the bug
As discussed with @Bober95 and @Valkirie in #52. Made a new ticket as requested by @NotYoojun

To Reproduce
Steps to reproduce the behavior:

  1. Navigate a "long" dropdown which has more elements then can be shown on the screen right away using the keyboard, either with the tab key or up and down arrows.

Expected behavior
I'm honestly not sure what would be best or easiest, but perhaps simply keeping the current selection/focus in view and scrolling automatically?

Screenshots
333068498-e5199f4a-35e5-4da6-9b33-07398a644246.webm

Desktop (please complete the following information):

  • OS: Windows 10, Windows 11
  • Version 10.0.19045 Build 19045
@Bober95
Copy link
Contributor

Bober95 commented May 24, 2024

I will also add that the same problem occurs in DataGrid, ScrollViewerEx is also used there

@Bober95
Copy link
Contributor

Bober95 commented Jul 3, 2024

Hi, I've been working on this problem for a while and I don't know exactly why it doesn't work, but removing this line solves the problem: ScrollInfo = new ScrollInfoAdapter(ScrollInfo); in file: ScrollViewerEx.cs

@CasperH2O
Copy link
Author

@NotYoojun thank you very much for the update and the new release (we updated right away, very exicted!).

In the release notes I read:

Disabled ForceUseSmoothScroll for ComboBox to fix the scrolling issues.

But could not pin point the commit that was relevant for this, can we consider this ticket closed/done now? 🙂

@NotYoojun
Copy link
Member

@NotYoojun thank you very much for the update and the new release (we updated right away, very exicted!).

In the release notes I read:

Disabled ForceUseSmoothScroll for ComboBox to fix the scrolling issues.

But could not pin point the commit that was relevant for this, can we consider this ticket closed/done now? 🙂

Hi there,
Is this problem fixed? If so, you can close this issue.
If something else happens, feel free to reopen.

@Bober95
Copy link
Contributor

Bober95 commented Jul 9, 2024

The problem is not resolved, it still occurs. The full solution is in my previous comment

@Valkirie
Copy link
Contributor

Valkirie commented Jul 9, 2024

**Bober95 ** commented

Any side effects ? If not, could you maybe produce a Pull Request ?

@NotYoojun
Copy link
Member

**Bober95 ** commented

Any side effects ? If not, could you maybe produce a Pull Request ?

There might be. I guess virtualization features will no longer work. More tests needed.

@Bober95 Bober95 mentioned this issue Aug 27, 2024
@NotYoojun
Copy link
Member

Hey,

Pls check after the latest commit if the problem still exists.

@CasperH2O
Copy link
Author

Hey,

Pls check after the latest commit if the problem still exists.

Will do @NotYoojun , thanks for the follow up and thank you @Bober95 for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants