Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

total organic carbon in soil #3

Open
mabablue opened this issue Mar 20, 2023 · 6 comments
Open

total organic carbon in soil #3

mabablue opened this issue Mar 20, 2023 · 6 comments

Comments

@mabablue
Copy link
Member

mabablue commented Mar 20, 2023

PID of Variable: http://vocabs.lter-europe.net/EnvThes/30325

Variable Description:

Property (label): amount of matter

Object of Interest (label): Carbon

Matrix (label): organic matter

Context Object(s) (label): soil

Constraint(s) (label) and which Entity it constraints:

Dimension Information:

Applicable Unit(s):

Link to a Publication of the Variable or Method:

Link to Turtle File (ttl) in this Repository (optional):

@gwemon
Copy link
Member

gwemon commented May 14, 2024

@mabablue Your property above says "amount of matter" yet it points to a concept in EnvThes that is "amount of substance". The SI units for "amont of substance" in the SI system is the mole: https://www.nist.gov/pml/owm/si-units-amount-substance. Do you expect/restrict the results to be expressed in a unit derived from moles? or could it also be expressed as a mass?

@mabablue
Copy link
Member Author

mabablue commented May 19, 2024

hi Gwen, thanks that is actually a typo... it should be amount of substance.
This is the corrected version:
variable: total organic carbon in soil
property: amount of substance
hasObjectOfInterest: carbon
matrix: organic matter
hasContextObject: soil

The unit used in Integrated Monitoring for TOC is: mg/kg

@mabablue
Copy link
Member Author

shouldn't we add hasApplicableUnit as extension to I-ADOPT?

@gwemon
Copy link
Member

gwemon commented May 20, 2024

Hi Barbara, if you define a variable as having a property "amount of substance" then the result is expected to be in a unit derived from "moles", the SI unit for amount-of-substance. What you have is a mass of carbon per mass of substrate. So you could define your I-ADOPT variable as that i.e. property is mass.
But also, because moles and mass of elemental composition are so easy to convert from one to another there is also the option to use a broader term for the property that could justify having units in moles or mass . This is the approach we took in the BODC PUV (that decision was taken a long long time ago!).

@gwemon
Copy link
Member

gwemon commented May 20, 2024

shouldn't we add hasApplicableUnit as extension to I-ADOPT?
I think that it is too early at this stage to decide this. There are multiple ways we could link the vrariable to its applicable units (directly with hasApplicable as you say or via the vector dimension. However before we consider this, we need a full understanding of the impact it will have. So it would be good to take the habit of considering the units when analysing/decomposing a variable. Then as we work with more examples, hopefully the best way to link the units to the variable will become more obvious.

@gwemon
Copy link
Member

gwemon commented May 20, 2024

Our closest P01 concept to your example would be: https://vocab.nerc.ac.uk/collection/P01/current/OCCNXXXX/ i.e. concentration of organic carbon measured in sediments. In the mapping it says unit is "percent" but this is just what BODC uses. Other users must specify the units alongside the P01 code.
If starting from fresh, I think that I would recommend creating a variable that is aligned to one vector dimension. i.e. in your case, [Mass] per [Mass]. In our case this is no longer possible.
However how do you capture the fact that this is relative to the "mass" of soil?
Alternatively you could have the property defined as "Proportion by weight" (i.e. [Mass] of Carbon in Organic Matter per [Mass] of soil etc... (see e.g. http://vocab.nerc.ac.uk/collection/S06/current/S0600067/)

@mabablue mabablue transferred this issue from another repository May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants