From 7fc4c1b73fcb29dc7d8abf9d5d68ca6da4bc443b Mon Sep 17 00:00:00 2001 From: Henner Zeller Date: Sun, 4 Aug 2024 03:56:40 -0700 Subject: [PATCH] Document why we're stuck in some older versions in bzlmod Some dependencies are written in a way that they require bazel 7, so can't use them yet. Also: Fix a typo in verible-ci --- .github/workflows/verible-ci.yml | 2 +- MODULE.bazel | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verible-ci.yml b/.github/workflows/verible-ci.yml index ad0a93dd6..3f31f0dd9 100644 --- a/.github/workflows/verible-ci.yml +++ b/.github/workflows/verible-ci.yml @@ -542,7 +542,7 @@ jobs: ls -lah artifact - name: Deploy release and assets - uses: svenstaro/upload-release-action@v2.9.0 + uses: svenstaro/upload-release-action@2.9.0 with: repo_token: ${{ secrets.GITHUB_TOKEN }} file: artifact/verible*.{tar.gz,zip} diff --git a/MODULE.bazel b/MODULE.bazel index 8d4329007..81f58cec1 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -51,6 +51,8 @@ flex.repository( use_repo(flex, "flex") register_toolchains("@flex//:toolchain") +# abseil-cpp can not be updated beyond the following curringly, as newer +# ones use googletest that is not compatible with bazel 6 anymore. bazel_dep(name = "abseil-cpp", version = "20240116.2", repo_name="com_google_absl") single_version_override( module_name = "abseil-cpp", @@ -60,6 +62,8 @@ single_version_override( ) bazel_dep(name = "re2", version = "2023-09-01", repo_name="com_googlesource_code_re2") + +# Newer versions require bazel 7, so this is the last we can use currently. bazel_dep(name = "googletest", version = "1.14.0.bcr.1", repo_name="com_google_googletest") bazel_dep(name = "protobuf", version = "26.0", repo_name="com_google_protobuf") bazel_dep(name = "nlohmann_json", version = "3.11.3", repo_name="jsonhpp")