Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make screen sharing dialog more responsive and/or allow resizing #175

Closed
devtrends opened this issue Jan 26, 2024 · 7 comments · Fixed by #176
Closed

Make screen sharing dialog more responsive and/or allow resizing #175

devtrends opened this issue Jan 26, 2024 · 7 comments · Fixed by #176

Comments

@devtrends
Copy link

The screen sharing dialog cuts off text when certain fonts are used:

image

I have tried resizing this with a window rule but it doesn't have any effect:

windowrule = size 600 300, title:MainPicker$
@vaxerski
Copy link
Member

There was a MR for that (#173) but the author for some reason got frustrated and closed it. I might remake the thing to be resizeable.

@rurigk
Copy link
Contributor

rurigk commented Jan 27, 2024

There was a MR for that (#173) but the author for some reason got frustrated and closed it. I might remake the thing to be resizeable.

Sorry i had a very very bad day, that mr was the product of frustration of not being able to resize and restore the size of the dialog

I think the easy way for the problem to remembering the size its to save it on /tmp and dont worry about any file
It will forget the size but just at least it will remember when the user is using the dialog

I will reopen the MR you can use the code if you want i just wanted a better experience for me and share it with others
I also apologize for closing the MR

You can cherry pick the size remembering thing if you really dont want the size to be remembered, in that case i will mantain the fork for personal use

@vaxerski
Copy link
Member

I believe remembering the size is not really needed as we have windowrules to deal with that. Adding more config files just because we wanna remember the size sounds kinda pointless

@rurigk
Copy link
Contributor

rurigk commented Jan 28, 2024

This should be fixed with #173
@devtrends can you give it a try?

@devtrends
Copy link
Author

Looks good to me. Window is resizable and respects window rules. It seems to remember last size (unless you force close dialog) Position of Allow a restore token on left is better. Only slight issue is the display of long window names (see 2nd item down) Arguably showing the start and ellipsizing might be better but really not a big deal. Nice job

image

rurigk added a commit to rurigk/xdg-desktop-portal-hyprland that referenced this issue Jan 29, 2024
It also fixes the region button size and alignment

fixes hyprwm#175
rurigk added a commit to rurigk/xdg-desktop-portal-hyprland that referenced this issue Jan 29, 2024
It also fixes the region button size and alignment

fixes hyprwm#175
@rurigk
Copy link
Contributor

rurigk commented Jan 29, 2024

@devtrends This problem should be solved by #176 can you give it a try?

vaxerski pushed a commit that referenced this issue Jan 29, 2024
It also fixes the region button size and alignment

fixes #175
@devtrends
Copy link
Author

@rurigk Perfect. Just tried it and it looks great.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants