Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyprctl Color and Icon problem #58

Merged
merged 9 commits into from
Jun 22, 2023
Merged

Conversation

ysekka
Copy link
Contributor

@ysekka ysekka commented Jun 19, 2023

I have told about on color problem before. They color codes had to be written in hex form, not rgb form.
I also found that there is no no-icon option. So I fix it too.

Copy link
Member

@yavko yavko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the notify command might not work with decimal number, but please keep the PR on topic, why are so many functions made public?

src/ctl.rs Show resolved Hide resolved
src/ctl.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@ysekka
Copy link
Contributor Author

ysekka commented Jun 20, 2023

Someone maybe wants to use those functions. For example, there is a guy who forked Hyprland and added some commands to it wants to interact with it by rust. That is clear that we cannot add every single commands of a hyprland fork to hyprland-rs. If someone wants to execute a custom command, he/she can do this. If a function which execute custom commands exists, I can make them pub(crate) again.

@ysekka ysekka requested a review from yavko June 20, 2023 14:42
@yavko
Copy link
Member

yavko commented Jun 20, 2023

Someone maybe wants to use those functions. For example, there is a guy who forked Hyprland and added some commands to it wants to interact with it by rust. That is clear that we cannot add every single commands of a hyprland fork to hyprland-rs. If someone wants to execute a custom command, he/she can do this. If a function which execute custom commands exists, I can make them pub(crate) again.

If they fork the repo, the functions will be available that's what pub(crate) means, it means it's available to the current crate? And I'm planning on introducing a better way of doing this that's more user oriented, so please reverse that. Also, please fix your commit names, this is a public project, such vague commit messages are not allowed. Preferably, make them into one through like a force push or something.

src/ctl.rs Outdated Show resolved Hide resolved
src/ctl.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/shared.rs Outdated Show resolved Hide resolved
src/ctl.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@ysekka
Copy link
Contributor Author

ysekka commented Jun 21, 2023

I converted all leftover pub's to pub(crate)s. I also fix the hex conversion and I replaced i8 with i32. I hope that I hadn't left anything.

@yavko
Copy link
Member

yavko commented Jun 21, 2023

The commit names are still not fixed

@yavko yavko merged commit 2102b86 into hyprland-community:master Jun 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants