-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hyprctl Color and Icon problem #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that the notify command might not work with decimal number, but please keep the PR on topic, why are so many functions made public?
Someone maybe wants to use those functions. For example, there is a guy who forked Hyprland and added some commands to it wants to interact with it by rust. That is clear that we cannot add every single commands of a hyprland fork to hyprland-rs. If someone wants to execute a custom command, he/she can do this. If a function which execute custom commands exists, I can make them pub(crate) again. |
If they fork the repo, the functions will be available that's what |
I converted all leftover pub's to pub(crate)s. I also fix the hex conversion and I replaced i8 with i32. I hope that I hadn't left anything. |
The commit names are still not fixed |
and the i32 of notification type cast also converted to i8
I have told about on color problem before. They color codes had to be written in hex form, not rgb form.
I also found that there is no no-icon option. So I fix it too.