feat: implement configreloaded event #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wait for #208 to get merged first, since changing implementations to the event listener stuff |
|
Can u rebase on master and check if it still works |
|
Never mind, that was before the big merge, but I'm not gonna rebase master, I'm gonna rebase add-events once you rebase that. |
Okay one sec |
|
NVM too much to fix, can't do on my phone |
yavko
requested changes
May 3, 2024
|
also fix the merge conflicts |
diniamo
force-pushed
the
add-configreloaded
branch
from
9ae912a
to
757d1c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yavko rebase on master after you merge this please