Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.4 #177

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Merge branch 'master' into add-events

3c8304e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Version 0.4 #177

Merge branch 'master' into add-events
3c8304e
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Sep 3, 2024 in 0s

clippy

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.83.0-nightly (bd53aa3bf 2024-09-02)
  • cargo 1.83.0-nightly (c1fa840a8 2024-08-29)
  • clippy 0.1.82 (bd53aa3 2024-09-02)

Annotations

Check warning on line 64 in src/event_listener/stream.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

you should consider adding a `Default` implementation for `EventStream`

warning: you should consider adding a `Default` implementation for `EventStream`
  --> src/event_listener/stream.rs:35:5
   |
35 | /     pub fn new() -> Self {
36 | |         use crate::unix_async::*;
37 | |         let stream = try_stream! {
...  |
63 | |         }
64 | |     }
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
   = note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
   |
33 + impl Default for EventStream {
34 +     fn default() -> Self {
35 +         Self::new()
36 +     }
37 + }
   |

Check warning on line 903 in src/event_listener/shared.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

warning: redundant closure
   --> src/event_listener/shared.rs:903:26
    |
903 |                     .map(|x| Address::new(x))
    |                          ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Address::new`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 705 in src/event_listener/shared.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> src/event_listener/shared.rs:705:30
    |
705 |                     x.splitn(event.0 as usize, ",")
    |                              ^^^^^^^^^^^^^^^^ help: try: `event.0`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 694 in src/event_listener/shared.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
   --> src/event_listener/shared.rs:694:6
    |
694 | ) -> crate::Result<Either<(ParsedEventType, Vec<String>), (String, String)>> {
    |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
    = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 466 in src/event_listener/shared.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

first doc comment paragraph is too long

warning: first doc comment paragraph is too long
   --> src/event_listener/shared.rs:464:1
    |
464 | / /// This struct represents an unknown event to hyprland-rs
465 | | /// this allows you to use events that haven't been implemented in hyprland-rs.
466 | | /// To use this use the [UnknownEventData::parse_args] method to properly get the args
    | |_
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph
    = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default

Check warning on line 75 in src/event_listener/shared.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this lifetime isn't used in the function definition

warning: this lifetime isn't used in the function definition
  --> src/event_listener/shared.rs:75:35
   |
75 | pub(crate) fn event_primer_noexec<'a>(
   |                                   ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
   = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default