update tests for same

hyperweb-io · Jan 2, 2024 · 1cadb8e · 1cadb8e
1 parent cc02ac3
commit 1cadb8e
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 9 deletions.
diff --git a/registry/handler.go b/registry/handler.go
@@ -257,9 +257,7 @@ func (a *AppServer) ListIBC(ctx context.Context, _ *emptypb.Empty) (*pb.Response
 			return nil, err
 		}
 
-		for _, info := range infos {
-			resData = append(resData, info.ToProto())
-		}
+		resData = append(resData, infos.ToProto()...)
 	}
 
 	return &pb.ResponseListIBC{Data: resData}, nil

diff --git a/registry/model.go b/registry/model.go
@@ -143,8 +143,8 @@ func (info *ChainIBCInfo) ToProto() *pb.IBCData {
 
 // GetCounterpartyChainInfo returns ChainIBCInfo struct for given counterparty
 // chain id.
-func (c ChainIBCInfos) GetCounterpartyChainInfo(chainId string) *ChainIBCInfo {
-	for _, cii := range c {
+func (infos ChainIBCInfos) GetCounterpartyChainInfo(chainId string) *ChainIBCInfo {
+	for _, cii := range infos {
 		if cii.Counterparty.ChainId == chainId {
 			return cii
 		}

diff --git a/tests/e2e/configs/two-chain.yaml b/tests/e2e/configs/two-chain.yaml
@@ -30,11 +30,14 @@ relayers:
       global:
         log_level: "error"
       rest:
-        enabled: false
+        enabled: true
       telemetry:
         enabled: false
       event_source:
         mode: pull
+    ports:
+      rest: 3000
+      exposer: 3002
 
 explorer:
   enabled: true
@@ -52,4 +55,4 @@ registry:
     grpc: 9091
 
 exposer:
-  image: ghcr.io/cosmology-tech/starship/exposer:20231215-7c22b86
+  image: anmol1696/exposer:20240102-cc02ac3
diff --git a/tests/e2e/exposer_test.go b/tests/e2e/exposer_test.go
@@ -160,6 +160,8 @@ func (s *TestSuite) TestExposer_CreateChannel() {
 		}
 
 		// get number of channels before creating channel
+		ibcDataBefore := s.getIBCData(relayer.Chains[0], relayer.Chains[1])
+		s.Require().GreaterOrEqual(len(ibcDataBefore.Channels), 1, ibcDataBefore)
 
 		body := map[string]string{
 			"a_chain":      relayer.Chains[0],
@@ -179,6 +181,10 @@ func (s *TestSuite) TestExposer_CreateChannel() {
 		err = json.NewDecoder(resp).Decode(&res)
 		s.Require().NoError(err)
 
-		s.Require().Contains("SUCCESS Channel", res["status"].(string), "response from exposer creaste_channel", res)
+		s.Require().Contains(res["status"].(string), "SUCCESS Channel", "response from exposer creaste_channel", res)
+
+		// get number of channels after creating channel
+		ibcDataAfter := s.getIBCData(relayer.Chains[0], relayer.Chains[1])
+		s.Require().Len(ibcDataAfter.Channels, len(ibcDataBefore.Channels)+1, "number of channels should be 1 more then before", ibcDataAfter)
 	}
 }
diff --git a/tests/e2e/faucet_test.go b/tests/e2e/faucet_test.go
@@ -89,6 +89,16 @@ func (s *TestSuite) getChainDenoms(chain *Chain) string {
 	return respChain.Fees.FeeTokens[0].Denom
 }
 
+func (s *TestSuite) getIBCData(aChain, bChain string) *pb.IBCData {
+	req, err := http.NewRequest(http.MethodGet, fmt.Sprintf("/ibc/%s/%s", aChain, bChain), nil)
+	s.Require().NoError(err)
+
+	ibcData := &pb.IBCData{}
+	s.MakeRegistryRequest(req, ibcData)
+
+	return ibcData
+}
+
 func (s *TestSuite) getAccountBalance(chain *Chain, address string, denom string) float64 {
 	data := map[string]interface{}{}
 	s.MakeChainGetRequest(chain, fmt.Sprintf("/cosmos/bank/v1beta1/balances/%s", address), &data)

diff --git a/tests/e2e/registry_test.go b/tests/e2e/registry_test.go
@@ -276,7 +276,7 @@ func (s *TestSuite) TestRegistry_ListIBC() {
 	s.MakeRegistryRequest(req, respIBC)
 
 	// assert results to expected values
-	s.Require().Len(respIBC.Data, len(s.config.Relayers)*2, "number of ibc information should be double the number of relayers")
+	s.Require().GreaterOrEqual(len(respIBC.Data), len(s.config.Relayers)*2, "number of ibc information should be double the number of relayers")
 }
 
 func (s *TestSuite) TestRegistry_GetChainKeys() {