Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support phpseclib V3 #132

Open
fernandocoronatomf opened this issue Jul 17, 2024 · 5 comments
Open

Support phpseclib V3 #132

fernandocoronatomf opened this issue Jul 17, 2024 · 5 comments

Comments

@fernandocoronatomf
Copy link

Hey there,

We could really use some help getting phpseclib V3 support up and running—it's crucial for our application. I've tried updating the version in composer.json, but we're hitting a roadblock with the 'gree/jose' package, which hasn't been maintained in 8 years and remains a key dependency, even in HW SDK v4.

Do you have any plans to replace this package with a more maintained one like lcobucci/jwt? That would be a game-changer for us.

@fernandocoronatomf
Copy link
Author

@grmeyer-hw-dev Can we maybe bring the gree/jose old not-maintaned package to inside hyperwallet/sdk so we can correct the namespaces? I think besides replacing the whole JWT package that would be an easier and quicker solution for now.

If I do the change would you merge it? I just need to make sure you're ok with it, we really need phpseclib v3

@grmeyer-hw-dev
Copy link
Collaborator

HI @fernandocoronatomf

I saw your Initial PR, and I tried to update too but it requires more change upgrade to phpseclib V3.

If I do the change would you merge it? Yes, just raise a PR, the goal is to get green on the GitHub Actions, and we can review and get your PR merged.

@grmeyer-hw-dev
Copy link
Collaborator

HI @fernandocoronatomf

Can we maybe bring the gree/jose old not-maintaned package to inside hyperwallet/sdk ?
Short answer is no, We can't bring gree/Jose to the SDK for some reasons for reasons like:

  • Copy/rights or legal reasons
  • maintenance

But we can replace it for sure, Do you know any other option for gree/Jose ?

@fernandocoronatomf
Copy link
Author

HI @fernandocoronatomf

Can we maybe bring the gree/jose old not-maintaned package to inside hyperwallet/sdk ? Short answer is no, We can't bring gree/Jose to the SDK for some reasons for reasons like:

  • Copy/rights or legal reasons
  • maintenance

But we can replace it for sure, Do you know any other option for gree/Jose ?

Hmm I actually raised an MR and all the checks passed. If you don't want to do that I guess because I brought the package inside the hyperwallet SDK, you could try using

firebase/php-jwt
https://github.com/lcobucci/jwt

@fernandocoronatomf
Copy link
Author

My PR #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants