Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removal of all longlat text #57

Open
mdsumner opened this issue Jun 6, 2024 · 1 comment
Open

consider removal of all longlat text #57

mdsumner opened this issue Jun 6, 2024 · 1 comment

Comments

@mdsumner
Copy link
Member

mdsumner commented Jun 6, 2024

@anthonynorth

I'm toying with this in a branch, it seems PROJ 8.2.1 which is what rhub Ubuntu-asan uses has problems with user input "+proj=longlat*" or "OGC:CRS84". I've had to clean them out of vapour, and doing that here results in clean asan tests (not valgrind)

I don't yet know why PROJ on CRAN is not triggering similar "extra checks" problems as vapour is

@anthonynorth
Copy link
Collaborator

Is this related to the below commented out test?

## we can't use proj=longlat or OGC:CRS84 with PROJ 8.2.1 and ubuntu-asan
# test_that("proj_trans_create() adds crs type if needed", {
# expect_no_error(proj_trans_create("+proj=longlat +datum=WGS84 +no_defs +type=crs", "+proj=longlat +datum=WGS84 +no_defs"))
#
# info <- proj_trans_info(
# proj_trans_create(
# "+proj=longlat +datum=WGS84 +no_defs +type=crs",
# "+proj=longlat +datum=WGS84 +no_defs"
# )
# )
#
# expect_identical(info$source_crs, info$target_crs)
# })

It may be related to creating a noop transform?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants