Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ergonomic MST #4930

Open
mversic opened this issue Aug 2, 2024 · 6 comments · Fixed by #5027
Open

Ergonomic MST #4930

mversic opened this issue Aug 2, 2024 · 6 comments · Fixed by #5027
Assignees
@s8sato

Comments

@mversic
Copy link
Contributor

mversic commented Aug 2, 2024 •
edited
Loading

Ideas on how can we make MST more ergonomic:

  1. All smart contracts for MST should be registered from Executor, i.e. be put in default executor migration
  2. I think we need an API to fetch all currently voted for transactions, i.e. pending transactions
  3. we need a way to expire MST that have not been active for a while
  4. We can define custom instructions for dealing with MST and also have them defined as part of default executor

Additionally, we should consider adding (behind a feature flag "mst") a specialized API to both iroha client and cli for dealing with MSTs.
@mversic
Copy link
Contributor Author

mversic commented Aug 5, 2024

actually, instead of doing it during executor migration as was suggested in 1. they should be registered in the genesis

@s8sato s8sato self-assigned this Aug 20, 2024
@s8sato s8sato mentioned this issue Sep 3, 2024
Merged
3 tasks
@s8sato
Copy link
Contributor

s8sato commented Oct 3, 2024 •
edited
Loading

Remaining issues after #5027:

@mversic
Copy link
Contributor Author

mversic commented Oct 18, 2024 

* [make the default multisig ttl indefinite?](https://github.com/hyperledger/iroha/pull/5027#discussion_r1742874965)

no, there should always be some default non-infinite value

@0x009922
Copy link
Contributor

My comment regarding the client interface: #5027 (comment)

I don't immediately like the idea of having this being included directly into the client. Though, it depends on how much we need to make multisig an official out-of-the-box feature.

As an alternative idea, there could a separate CLI to construct multisig-related instructions in a form of JSON, which then could be supplied to the client:

iroha_multisig register --account .. --weights .. --quorum .. | iroha json transaction

@s8sato
Copy link
Contributor

s8sato commented Oct 29, 2024

Accidentally automatically closed. Reopened

@s8sato s8sato reopened this Oct 29, 2024
@s8sato s8sato mentioned this issue Nov 2, 2024
Open
3 tasks
@s8sato
Copy link
Contributor

s8sato commented Nov 6, 2024

  • well-structured multisig list CLI command stdout
  • override account-level TTL with transaction-level one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s8sato s8sato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve multisig utility and usability s8sato/iroha
3 participants
@0x009922 @mversic @s8sato