Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View change with large number #940

Open
dastardlychimp opened this issue Oct 9, 2018 · 1 comment
Open

View change with large number #940

dastardlychimp opened this issue Oct 9, 2018 · 1 comment
Labels
discussing Under further discussion.

Comments

@dastardlychimp
Copy link

dastardlychimp commented Oct 9, 2018

When there is an integer in the request that is larger than a 64 bit integer (9223372036854775807), the ujson package throws an uncaught value error which results in a view change.

Stacktrace:

Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/stp_zmq/zstack.py", line 565, in processReceived
    msg = self.deserializeMsg(msg)
  File "/usr/local/lib/python3.5/dist-packages/stp_zmq/zstack.py", line 835, in deserializeMsg
    msg = json.loads(msg)
ValueError: Value is too big

zstack.py

    @staticmethod
    def deserializeMsg(msg):
        if isinstance(msg, bytes):
            msg = msg.decode()
>>      msg = json.loads(msg)
        return msg
@esplinr
Copy link
Contributor

esplinr commented Oct 12, 2018

We will track this as:
https://jira.hyperledger.org/browse/INDY-1760

@WadeBarnes WadeBarnes added the discussing Under further discussion. label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussing Under further discussion.
Projects
None yet
Development

No branches or pull requests

3 participants