Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version mismatches between deb and pypi packages (.(dev|rc) vs ~(dev|rc)) #1781

Open
pSchlarb opened this issue Sep 16, 2022 · 3 comments
Open

Comments

@pSchlarb
Copy link
Contributor

The prepare_package.sh script changes the version number of plenum and node in the setup.py to match with the deb versioning (~).
fpm extracts that and writes the deb depends on correctly with the deb versioning.
The problem is in the final deb package, the requires.txt lists the pypi version in the deb format with the ~ in it.
If someone only install with apt and uses indy-node /plenum it isn't noticeable.
If someone on the other hand wants to install the sovrin package pip checks that setup.py sees the already (with apt) installed indy-node but tries to load the dependencies listed in the requires.txt from pypi, which obviously fails due to the version mismatch. (Pypi only has the package with the .)
If the apt package of indy-node is removed and only installed via pip the problem doesn't exists. (since the changes in #1779 )

@WadeBarnes
Copy link
Member

@pSchlarb, Did we ever solve this issue?

@pSchlarb
Copy link
Contributor Author

Hm i think we haven't really looked into it more.
And i think it is only the special case if someone wants to install mixed(apt and pypi installation) that this problem really occurs. Pure apt and pypi installation should be fine.

@WadeBarnes
Copy link
Member

Thanks. I recall better now. It's also not a problem for full releases.

The work here would involve a review of the Python and deb package versioning schemes to see if there is a way to align the pre-release versioning so these version conflicts between the Python and deb packages don't occur.

To put it in the context of a user story. As a developer I would like to be able to install indy-node packages and dependances using a mix of deb and Python packages without running into unresolvable version numbering conflicts between the version dependencies listed in the deb install and the actual version numbers of the published python packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants