Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing y coordinate when restoring a public key #374

Closed

Conversation

elribonazo
Copy link
Contributor

Description:

Reported by @amagyar-iohk and @mineme0110, we are not restoring the public key properly when resolving the DIDS, when the Ed25519 and Secp256k1 key comes with x and y coordinated only x is being added.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link

github-actions bot commented Feb 5, 2025

Lines Statements Branches Functions
Coverage: 77%
78.13% (3742/4789) 68.07% (1729/2540) 82.13% (892/1086)

@coveralls
Copy link

coveralls commented Feb 5, 2025

Coverage Status

coverage: 74.459% (-0.05%) from 74.511%
when pulling 5be619a on feature/fix-ellliptic-jwk-by-coordinates-x-and-y
into 4fa5b1d on main.

@elribonazo elribonazo force-pushed the feature/fix-ellliptic-jwk-by-coordinates-x-and-y branch from 040d7da to 4840f25 Compare February 6, 2025 11:28
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
@elribonazo elribonazo force-pushed the feature/fix-ellliptic-jwk-by-coordinates-x-and-y branch from 4840f25 to 5be619a Compare February 6, 2025 11:28
@elribonazo elribonazo marked this pull request as ready for review February 6, 2025 11:29
@elribonazo elribonazo requested a review from a team as a code owner February 6, 2025 11:29
@elribonazo
Copy link
Contributor Author

Closing this PR in favor of this #369

@elribonazo elribonazo closed this Feb 6, 2025
@elribonazo elribonazo deleted the feature/fix-ellliptic-jwk-by-coordinates-x-and-y branch February 6, 2025 12:03
@elribonazo elribonazo restored the feature/fix-ellliptic-jwk-by-coordinates-x-and-y branch February 12, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants