From c18dd127089d7f7b0050730e105e6d9f856e07df Mon Sep 17 00:00:00 2001 From: alexey semenyuk Date: Tue, 3 Dec 2024 00:54:19 +0500 Subject: [PATCH 1/2] pull_request template Signed-off-by: alexey semenyuk --- .github/pull_request_template.md | 45 ++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 000000000..8cb3505fe --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,45 @@ + + +## Proposed changes + +Please include a summary of the changes here and why we need those changes. And also let us know which issue is fixed. + +Fixes # + +
+ +## Types of changes + + + + + +- [ ] Bug fix +- [ ] New feature added +- [ ] Documentation Update + +
+ +## Please make sure to follow these points + + + + + +- [ ] I have read the contributing guidelines. +- [ ] I have performed a self-review of my own code or work. +- [ ] I have commented my code, particularly in hard-to-understand areas. +- [ ] My changes generates no new warnings. +- [ ] My Pull Request title is in format < issue name > eg Added links in the documentation. +- [ ] I have added tests that prove my fix is effective or that my feature works. + +
+ +## Screenshots (If Applicable) + +
+ + +## Other Information + +Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc. From aaae065e8a098c37e1854d538793d15a3540d67b Mon Sep 17 00:00:00 2001 From: alexey semenyuk Date: Wed, 4 Dec 2024 01:35:10 +0500 Subject: [PATCH 2/2] Add coverage sentence Signed-off-by: alexey semenyuk --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 8cb3505fe..e883a79c0 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -32,6 +32,7 @@ Fixes # - [ ] My changes generates no new warnings. - [ ] My Pull Request title is in format < issue name > eg Added links in the documentation. - [ ] I have added tests that prove my fix is effective or that my feature works. +- [ ] My changes have sufficient code coverage (unit, integration, e2e tests).