Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between CLI executable name based on install source #334

Open
shorsher opened this issue Jan 7, 2025 · 2 comments
Open

Discrepancy between CLI executable name based on install source #334

shorsher opened this issue Jan 7, 2025 · 2 comments

Comments

@shorsher
Copy link
Member

shorsher commented Jan 7, 2025

When installing the CLI through homebrew, firefly is the name of the executable. However, ff is the name of the executable when downloading the binary release or using go install.

@EnriqueL8
Copy link
Contributor

If I remember correctly for homebrew it has to be named the same as the package so firefly we can change our go build command inside the Makefile to just output the binary with the name firefly and also the cobra settings.

@dwertent
Copy link
Contributor

dwertent commented Jan 8, 2025

The naming convention is derived from the main.go directory's name. To implement a quick fix, we can rename the ff directory to firefly. The remaining time will be focused on updating all occurrences of ff in the documentation to reflect this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants