Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FirstEvent configurable to better support public chain with multi-party #331

Open
Chengxuan opened this issue Nov 15, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Chengxuan
Copy link

Chengxuan commented Nov 15, 2024

As per the discussion here: https://discord.com/channels/905194001349627914/1306104244486668369/1306929797296816200, Firefly-cli currently hard code the starting block of the Firefly batch pin contract event to 0 to ensure no events could be missed. But this is impractical when using multi-party mode with a public chain:

Workaround

The currently workaround is to update the firefly_core yaml generated manually to start indexing the events from a desired block number. (hint: newest can be used if you don't care about missing events which breaks integrity of indexed data)

An enhancement would be making the FirstEvent configurable

@Chengxuan Chengxuan changed the title Make FirstEvent configurable Make FirstEvent configurable to better support public chain with multi-party Nov 15, 2024
@EnriqueL8 EnriqueL8 added bug Something isn't working good first issue Good for newcomers and removed bug Something isn't working labels Nov 15, 2024
MKVEERENDRA added a commit to MKVEERENDRA/firefly-cli1 that referenced this issue Nov 17, 2024
MKVEERENDRA added a commit to MKVEERENDRA/firefly-cli1 that referenced this issue Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants