Default value for min peers before starting sync from 5 to 1 #7640
Conversation
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
|
I think I'm in favour of this change. The |
|
since it could make sense for private networks, for public ones that could increase the risk of syncing to the wrong fork, so could be possible to condition this on the basis if the network is public or private? probably looking at the presence or not of a custom genesis file? |
fab-10
added
the
doc-change-required
m4sterbunny
removed
the
doc-change-required
ok I think to be on the safe side, we can leave this default as is. The "Private network" tutorials have been updated to use the enterprise profile so users won't strike this issue when following tutorials which is how it came up. |
public PoA networks will still be using a custom genesis, right? so that wouldn't be a differentiator |
|
you are right, since Goerli is no more |
PR description
Change default value for minimum number of peers required before starting sync (only used by non-PoS networks) from 5 to 1.
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests