Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use peer transfer rate for peer selection #7697

Open
jframe opened this issue Oct 1, 2024 · 1 comment
Open

Use peer transfer rate for peer selection #7697

jframe opened this issue Oct 1, 2024 · 1 comment
Assignees
Labels
P2 High (ex: Degrading performance issues, unexpected behavior of core features (DevP2P, syncing, etc)) syncing

Comments

@jframe
Copy link
Contributor

jframe commented Oct 1, 2024

Use a peer reputation that scores peers using their transfer rate instead of the current system of penalising for timeouts and bad responses. When investigating the syncing of the chain, we noticed a large variation in peer transfer rates and this can make a large difference in the time taken to complete syncing.

@jframe jframe added the syncing label Oct 1, 2024
@jflo jflo added the P2 High (ex: Degrading performance issues, unexpected behavior of core features (DevP2P, syncing, etc)) label Oct 8, 2024
@jflo
Copy link
Contributor

jflo commented Oct 8, 2024

Great idea, needs to also preserve type of peer, so we don't favor a fast peer that only provides blocks over one that might also provide state. It's worth any refactoring needed to track these added dimensions.

@jframe jframe self-assigned this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 High (ex: Degrading performance issues, unexpected behavior of core features (DevP2P, syncing, etc)) syncing
Projects
None yet
Development

No branches or pull requests

2 participants