Make merkle tree leaf addition operations atomic #71
Conversation
Signed-off-by: Jim Zhang <[email protected]>
Signed-off-by: Jim Zhang <[email protected]>
| // the node's reference key (not the index) is used as the key to | ||
| // store the node in the DB | ||
| n := core.SMTNode{ | ||
| RefKey: ref.Hex(), | ||
| } | ||
| err := s.p.DB().Table(s.nodesTableName).First(&n).Error | ||
| err := batchOrDb.Table(nodesTableName).First(&n).Error |
There was a problem hiding this comment.
I'm struggling why a read operation would need a batch transaction
There was a problem hiding this comment.
here we want the query to hit the records that have been added in the batch, but have not been committed.
There was a problem hiding this comment.
but if you are looking relying on getNode before inserting then you need to make sure to use the DB directly instead of batch
| if _, err := batch.GetNode(k); err == nil { | ||
| return nil, ErrNodeIndexAlreadyExists | ||
| } | ||
| err := mt.db.InsertNode(n) | ||
| err := batch.InsertNode(n) |
There was a problem hiding this comment.
This is where I don't understand the batch function where you get a node but the TX is not committed yet and then you are adding an insert to the same transaction
There was a problem hiding this comment.
for example here, you would use db instead of batch for GetNode?
There was a problem hiding this comment.
After a conversation with @jimthematrix , we can move to ON CONFLICT insert and if there is on conflict do nothing and rework the way the read works
Signed-off-by: Jim Zhang <[email protected]>
|
@EnriqueL8 thanks for catching that. just added a commit to make the inserts `ON CONFLICT DO NOTHING" with a justification in the inline comments |
fixes #21