Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eth] Designated Funding timeout #5

Open
ggwpez opened this issue Oct 14, 2021 · 0 comments
Open

[eth] Designated Funding timeout #5

ggwpez opened this issue Oct 14, 2021 · 0 comments

Comments

@ggwpez
Copy link

ggwpez commented Oct 14, 2021

Location

[backend/eth/channel] Funder.Fund:135

Problem

The Ethereum Funder uses the ChallengeDuration as funding timeout which is just a "best effort" solution.
A problem arises in honest tests where the funding times out too quickly when ChallengeDuration=1 is used.
Concrete: The HLL talk example code has this problem.

Proposal

The user should be able to set a designated funding timeout.

Just adding an option to the client.Propose function would not be enough since the receiver of the proposal would need to be able to set his timeout as well.
The solution that i had in mind does not seem to work, so i will leave the concept open for later.

RmbRT referenced this issue in hyperledger-labs/go-perun Feb 8, 2022
The adjudicator test has a funding timeout of one challenge duration
(measured in blocks), but the challenge duration was in the range
[0, 3600). Now, it is generated in the range[200, 3600).

Issue #239 (adding a designated funding timeout parameter) would solve
this problem in a cleaner way, however, the implementation concept is
still unclear.

Signed-off-by: Steffen Rattay <[email protected]>
RmbRT referenced this issue in hyperledger-labs/go-perun Feb 9, 2022
The adjudicator test has a funding timeout of one challenge duration
(measured in blocks), but the challenge duration was in the range
[0, 3600). Now, it is generated in the range[200, 3600).

Issue #239 (adding a designated funding timeout parameter) would solve
this problem in a cleaner way, however, the implementation concept is
still unclear.

Signed-off-by: Steffen Rattay <[email protected]>
RmbRT referenced this issue in hyperledger-labs/go-perun Feb 9, 2022
The adjudicator test has a funding timeout of one challenge duration
(measured in blocks), but the challenge duration was in the range
[0, 3600). Now, it is generated in the range[200, 3600).

Issue #239 (adding a designated funding timeout parameter) would solve
this problem in a cleaner way, however, the implementation concept is
still unclear.

Signed-off-by: Steffen Rattay <[email protected]>
RmbRT referenced this issue in hyperledger-labs/go-perun Feb 9, 2022
The adjudicator test has a funding timeout of one challenge duration
(measured in blocks), but the challenge duration was in the range
[0, 3600). Now, it is generated in the range[200, 3600).

Issue #239 (adding a designated funding timeout parameter) would solve
this problem in a cleaner way, however, the implementation concept is
still unclear.

Signed-off-by: Steffen Rattay <[email protected]>
RmbRT referenced this issue in hyperledger-labs/go-perun Feb 9, 2022
The adjudicator test has a funding timeout of one challenge duration
(measured in blocks), but the challenge duration was in the range
[0, 3600). Now, it is generated in the range[200, 3600).

Issue #239 (adding a designated funding timeout parameter) would solve
this problem in a cleaner way, however, the implementation concept is
still unclear.

Signed-off-by: Steffen Rattay <[email protected]>
matthiasgeihs referenced this issue in hyperledger-labs/go-perun Feb 9, 2022
The adjudicator test has a funding timeout of one challenge duration
(measured in blocks), but the challenge duration was in the range
[0, 3600). Now, it is generated in the range[200, 3600).

Issue #239 (adding a designated funding timeout parameter) would solve
this problem in a cleaner way, however, the implementation concept is
still unclear.

Signed-off-by: Steffen Rattay <[email protected]>
@matthiasgeihs matthiasgeihs transferred this issue from hyperledger-labs/go-perun Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant