Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Consider tagging submodule "spi"? #3530

Open
Rick-xuy opened this issue Feb 17, 2023 · 0 comments
Open

Consider tagging submodule "spi"? #3530

Rick-xuy opened this issue Feb 17, 2023 · 0 comments

Comments

@Rick-xuy
Copy link

I found that package github.com/hyperledger/aries-framework-go/spi/storage is placed in submodule github.com/hyperledger/aries-framework-go/spi instead of root module.

However, it seems that submodule github.com/hyperledger/aries-framework-go/spi is not tagged. According to Go Modules wiki, submodule should be tagged like relative-path-to-root/vX.X.X.
At now, when trying to import package github.com/hyperledger/aries-framework-go/spi/storage, downstream would depends on pseudo-version of module github.com/hyperledger/aries-framework-go/spi.

github.com/hyperledger/aries-framework-go/spi v0.0.0-20211206182816-9cdcbcd09dc2

I think it is not very readable and difficult to upgrade. This is not conductive to version control either.
So, I propose whether it is possible to tag submodule properly. For example, spi/v0.0.1, spi/v0.1.8etc, so that other project can use tag to import this module in go.mod.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant