Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor deployer constructors to have an "options" object for optional args #5443

Open
paulbalaji opened this issue Feb 12, 2025 · 0 comments
Labels

Comments

@paulbalaji
Copy link
Contributor

In the current EvmIsmModule, we have a constructor that takes some optional arguments like a ccip contracts cache and contractVerifier

  constructor(
    protected readonly multiProvider: MultiProvider,
    params: HyperlaneModuleParams<
      IsmConfig,
      HyperlaneAddresses<ProxyFactoryFactories> & IsmModuleAddresses
    >,
    ccipContractCache?: CCIPContractCache,
    protected readonly contractVerifier?: ContractVerifier,
  ) {

Any time we need to extend this, it requires an update to any caller and subsequently any caller further up the chain of calls. Instead, we should have a single "options" object which contains optional arguments of ccipContractCache, contractVerifier and anything else that might get added in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant