Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getRegistry to registry package #5403

Open
nambrot opened this issue Feb 7, 2025 · 1 comment
Open

Move getRegistry to registry package #5403

nambrot opened this issue Feb 7, 2025 · 1 comment
Assignees

Comments

@nambrot
Copy link
Contributor

nambrot commented Feb 7, 2025

Move https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/nambrot/infra-checker-use-registry/node_modules/@hyperlane-xyz/cli/src/context/context.ts#L191 into the registry package, as it is not CLI specific

@mshojaei-txfusion
Copy link
Collaborator

I created these two PRs, one with OOP and the other one with functions,
@nambrot please take a look and let me know which one makes more sense so I would use it for mono-repo PR.

[I did this because registry code is implemented with classes and OOP, And IMO as we are moving more stuff from mono-repo to registry, that could be good idea to make a registry factory class for this case]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Sprint
Development

No branches or pull requests

2 participants