Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it work with CSP unsafe-eval? #35

Closed
silverwind opened this issue Sep 4, 2023 · 4 comments
Closed

Does it work with CSP unsafe-eval? #35

silverwind opened this issue Sep 4, 2023 · 4 comments

Comments

@silverwind
Copy link

Does this module would work with unsafe-eval?

If it does, this info should be added as a feature in the README, because it would be a major benefit compared to similar modules which require unsafe-eval, like these ones:

@silverwind silverwind changed the title Does it work with CSP unsave-eval? Does it work with CSP unsafe-eval? Sep 4, 2023
@jdesrosiers
Copy link
Collaborator

I haven't actually tried it myself, but there's no reason this package shouldn't work with unsafe-eval. There's no code that evaluates strings as JavaScript anywhere in this package.

@silverwind
Copy link
Author

Right, that sounds promising. If there are none of the 5 constructs mentioned on MDN in the codebase, you can be sure it will work.

@jdesrosiers
Copy link
Collaborator

I can confirm that none of those 5 constructs are used.

@silverwind
Copy link
Author

Good enough for me, thanks 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants