Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chop AddrStream out completely #2850

Closed
seanmonstar opened this issue May 20, 2022 · 4 comments · Fixed by #2869
Closed

Chop AddrStream out completely #2850

seanmonstar opened this issue May 20, 2022 · 4 comments · Fixed by #2869
Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
1.0 RC1

Comments

@seanmonstar
Copy link
Member

The AddrStream type can just go. Get out of here. Gone. It provides no benefit over tokio::net::TcpStream.
@seanmonstar seanmonstar added A-server Area: server. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. labels May 20, 2022
@seanmonstar seanmonstar added this to the 1.0 milestone May 20, 2022
@oddgrd
Copy link
Contributor

oddgrd commented May 24, 2022

Hi! I'd like to start contributing to this project, and this issue looks like a good place to start. I'm a bit of a rust and OSS noob, so I may need some guidance even though it should be easy.

oddgrd added a commit to oddgrd/hyper that referenced this issue May 24, 2022
@oddgrd
feat(server): remove addrstream struct
5824538 
remove addrstream type, it provides no benefit over tokio::net::tcpstream

closes issue hyperium#2850
oddgrd added a commit to oddgrd/hyper that referenced this issue May 24, 2022
@oddgrd
feat(server): remove addrstream struct
a2b365e 
remove addrstream type, it provides no benefit over tokio::net::tcpstream

closes issue hyperium#2850
@oddgrd oddgrd mentioned this issue May 24, 2022
Merged
oddgrd added a commit to oddgrd/hyper that referenced this issue May 25, 2022
@oddgrd
feat(server): remove addrstream struct
b53026c 
remove addrstream type, it provides no benefit over tokio::net::tcpstream

closes issue hyperium#2850
@seanmonstar seanmonstar linked a pull request May 25, 2022 that will close this issue
feat(server): remove addrstream struct #2869
Merged
@seanmonstar seanmonstar moved this to In Progress in hyper 1.0 May 25, 2022
Repository owner moved this from In Progress to Done in hyper 1.0 Jun 8, 2022
seanmonstar pushed a commit that referenced this issue Jun 8, 2022
@oddgrd
feat(server): remove AddrStream struct (#2869)
e9cab49 
remove addrstream type, it provides no benefit over tokio::net::tcpstream

Closes #2850
@nyetwurk
Copy link

nyetwurk commented Nov 16, 2023 •
edited
Loading

Is there a porting guide for code that refers to AddrStream?

https://github.com/Blockdaemon/solana-accountsdb-plugin-kafka/actions/runs/9867593533/job/27248214906?pr=272#step:8:722

@seanmonstar
Copy link
Member Author

There isn't currently such a guide, but I suggested making one in #3411.

allan2 added a commit to allan2/tonic that referenced this issue Dec 7, 2023
@allan2
Chop out AddrStream
6da14d8 
Replaced with `tokio::net::TcpStream`.
Inspired by hyperium/hyper#2850
ikrivosheev pushed a commit to ikrivosheev/tonic that referenced this issue Jan 10, 2024
@allan2 @ikrivosheev
Chop out AddrStream
a3f9d80 
Replaced with `tokio::net::TcpStream`.
Inspired by hyperium/hyper#2850
@Phoenix500526 Phoenix500526 mentioned this issue Mar 23, 2024
Closed
alexrudy pushed a commit to alexrudy/tonic that referenced this issue Apr 3, 2024
@allan2 @alexrudy
Chop out AddrStream
bef18d0 
Replaced with `tokio::net::TcpStream`.
Inspired by hyperium/hyper#2850
alexrudy pushed a commit to alexrudy/tonic that referenced this issue May 20, 2024
@allan2 @alexrudy
Chop out AddrStream
9f58136 
Replaced with `tokio::net::TcpStream`.
Inspired by hyperium/hyper#2850
alexrudy pushed a commit to alexrudy/tonic that referenced this issue May 21, 2024
@allan2 @alexrudy
Chop out AddrStream
d222f55 
Replaced with `tokio::net::TcpStream`.
Inspired by hyperium/hyper#2850
alexrudy pushed a commit to alexrudy/tonic that referenced this issue May 26, 2024
@allan2 @alexrudy
Chop out AddrStream
08b0eb6 
Replaced with `tokio::net::TcpStream`.
Inspired by hyperium/hyper#2850
@nyetwurk nyetwurk mentioned this issue Sep 19, 2024
Closed
@nyetwurk
Copy link

https://github.com/hyperium/hyper/pull/2869/files is somewhat self explanatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC1
Development

Successfully merging a pull request may close this issue.

feat(server): remove addrstream struct oddgrd/hyper
3 participants
@seanmonstar @nyetwurk @oddgrd