Skip to content

Update h2 to std::future #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seanmonstar opened this issue Jul 9, 2019 · 3 comments · Fixed by #1906
Closed

Update h2 to std::future #1851

seanmonstar opened this issue Jul 9, 2019 · 3 comments · Fixed by #1906
Labels
A-http2 Area: HTTP/2 specific. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.
Milestone
0.13

Comments

@seanmonstar
Copy link
Member

As part of the upgrade to std::future (#1805), the HTTP2 support was left as unimplemented!. This needs to be re-enabled, but depends on the h2 crate updating.
@seanmonstar seanmonstar added B-upstream Blocked: needs a change in a dependency or the compiler. E-hard Effort: hard. Likely requires a deeper understanding of how hyper's internals work. A-http2 Area: HTTP/2 specific. labels Jul 9, 2019
@seanmonstar seanmonstar added this to the 0.13 milestone Jul 9, 2019
@seanmonstar seanmonstar mentioned this issue Jul 19, 2019
Closed
5 tasks
@Kobzol
Copy link

Kobzol commented Jul 23, 2019

Is there an issue/PR/branch that is tracking the update of h2 to std::future, is anyone working on it currently?

@seanmonstar
Copy link
Member Author

Related issue in the h2 repo: hyperium/h2#385

@seanmonstar
Copy link
Member Author

The relevant work in the h2 crate has merged! Next up: re-enabling the http2 stuff inside hyper. It should be a bit easier, mostly just translating old Future to new.

@seanmonstar seanmonstar added E-medium Effort: medium. Some knowledge of how hyper internal works would be useful. and removed B-upstream Blocked: needs a change in a dependency or the compiler. E-hard Effort: hard. Likely requires a deeper understanding of how hyper's internals work. labels Aug 17, 2019
@seanmonstar seanmonstar mentioned this issue Aug 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-http2 Area: HTTP/2 specific. E-medium Effort: medium. Some knowledge of how hyper internal works would be useful.
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Re-enable HTTP2 support hyperium/hyper
2 participants
@seanmonstar @Kobzol